On hover text gets underlined

RESOLVED FIXED in mozilla2.0b8

Status

()

Core
Layout
P3
normal
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: dbaron)

Tracking

({regression, testcase})

Trunk
mozilla2.0b8
regression, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

(URL)

Attachments

(9 attachments, 4 obsolete attachments)

219 bytes, text/html
Details
457 bytes, application/xhtml+xml
Details
706 bytes, text/html; charset=UTF-8
Details
689 bytes, text/html; charset=UTF-8
Details
995 bytes, text/html; charset=UTF-8
Details
979 bytes, text/html; charset=UTF-8
Details
1.14 KB, text/html; charset=UTF-8
Details
634 bytes, text/html; charset=UTF-8
Details
16.08 KB, patch
roc
: review+
Details | Diff | Splinter Review
(Reporter)

Description

7 years ago
Created attachment 451971 [details]
testcase

On the url, when hovering over the text, it gets underlined. This doesn't happen on branch builds, because the parser terminates the <a>-tag directly.
This doesn't happen anymore with the new html5 parser. IE and Google Chrome also don't seem to do this, but they don't underline the text either, so perhaps Mozilla should have some default css rule to prevent text inside tables to get underlined when the table is also inside an anchor?
(Assignee)

Comment 1

7 years ago
There are a bunch of competing issues in this testcase:  parsing, block-within-inline handling, and the rules for propagation of text-decoration.  We have some known bugs with the last, but I don't remember exactly what the spec says for text-decoration rules.
The same parses the same way in Minefield and Chrome beta channel.
Duplicate of this bug: 562039

Updated

7 years ago
Duplicate of this bug: 601425

Comment 5

7 years ago
This bug is quirksmode only.

Request blocking because it affects Ebay forums (bug 601425). I saw it on other sites as well.
blocking2.0: --- → ?

Comment 6

7 years ago
> This bug is quirksmode only.

Yes, see the "text-decoration" part of comment 1.
(Assignee)

Updated

7 years ago
Assignee: nobody → dbaron
blocking2.0: ? → betaN+
(Assignee)

Comment 7

7 years ago
According to the (still member confidential, unfortunately) editor's draft of CSS 2.1, our text-decoration behavior here is correct.
(Assignee)

Comment 8

7 years ago
The text in question in the editor's draft is the first bit of:
http://lists.w3.org/Archives/Public/www-style/2010Aug/0334.html
(Assignee)

Comment 9

7 years ago
Then again, Chromium has too much underlining on these tests (whereas we have too little):
http://test.csswg.org/suites/css2.1/20101001/xhtml1/text-decoration-086.xht
http://test.csswg.org/suites/css2.1/20101001/xhtml1/text-decoration-088.xht
http://test.csswg.org/suites/css2.1/20101001/html4/text-decoration-086.htm
http://test.csswg.org/suites/css2.1/20101001/html4/text-decoration-088.htm
but still doesn't underline the text in attachment 451971 [details].

However, the actual relevant difference in our text-decoration behavior isn't the handling of inlines, it's the handling of tables.  Chromium doesn't propagate text-decorations into a table from anything (block or inline) outside of it; we do (as I *think* is required by the spec).
(Assignee)

Comment 10

7 years ago
Created attachment 484575 [details]
additional testcases
(Assignee)

Comment 11

7 years ago
http://lists.w3.org/Archives/Public/www-style/2010Oct/0407.html
(Assignee)

Comment 12

7 years ago
(And I'd note the CSS 2.1 test suite has no tests testing propagation into tables.)

Updated

7 years ago
Blocks: 610454
(Assignee)

Comment 13

7 years ago
Created attachment 491732 [details]
more HTML testcases, standards mode
(Assignee)

Comment 14

7 years ago
Created attachment 491734 [details]
more HTML testcases, quirks mode
(Assignee)

Comment 15

7 years ago
Created attachment 491738 [details]
more HTML testcases, standards mode
Attachment #491732 - Attachment is obsolete: true
(Assignee)

Comment 16

7 years ago
Created attachment 491739 [details]
more HTML testcases, quirks mode
Attachment #491734 - Attachment is obsolete: true
(Assignee)

Comment 17

7 years ago
based on attachment 491738 [details] and attachment 491739 [details]:

Differences between mozilla-central and Firefox 3.6:
 * propagation of standards-mode text-decoration from blocks to tables (we now underline)
 * parsing of <a> without an </a> (quirky handling removed)

Differences between mozilla-central and Chromium:
 * propagation of standards-mode text-decoration from blocks to tables (we underline)
 * propagation of quirks-mode text-decoration from blocks and inlines to tables (we underline)

Differences between mozilla-central and Opera:
 * propagation of standards-mode text-decoration from inlines to tables (they underline)
 * propagation of quirks-mode text-decoration from blocks and inlines to tables (we underline)

I'd like to test IE7, IE8, and IE9, but given what I know so far, I think Opera's behavior is the most sensible, and we should make our quirks-mode text-decoration handling more quirky and (perhaps not in this bug) our standards-mode text-decoration handling follow the spec.
(Assignee)

Comment 18

7 years ago
It looks like IE8 matches Opera (I'd need to double-check the standards-mode case, but I'm pretty sure I'm remembering the quirks-mode case correctly).
(Assignee)

Comment 19

7 years ago
However, the original URL for the testcases for this bug and bug 562039 are in standards mode.

That said, the eBay forums (bug 601425) are in quirks mode; they're probably the most important to fix.
(Assignee)

Comment 20

7 years ago
That said, I don't see any problems on the two pages that are in standards mode (http://www.netwerknotarissen.nl/page.asp?id=10722&menu=8&kid=2 and http://www.camino.pl/ ).
(Assignee)

Comment 21

7 years ago
Created attachment 491883 [details]
less-related testcases, standards mode
(Assignee)

Comment 22

7 years ago
Created attachment 491885 [details]
less-related testcases, quirks mode
(Assignee)

Comment 23

7 years ago
Created attachment 491887 [details]
less-related testcases, standards mode
Attachment #491883 - Attachment is obsolete: true
(Assignee)

Comment 24

7 years ago
Created attachment 491888 [details]
less-related testcases, quirks mode
Attachment #491885 - Attachment is obsolete: true
(Assignee)

Comment 25

7 years ago
Created attachment 491892 [details]
more quirks mode table cases
(Assignee)

Comment 26

7 years ago
Created attachment 491898 [details]
quirks mode which-table-element testcases
(Assignee)

Comment 27

7 years ago
I have a patch, but want to write additional tests.

I'm planning to make two changes:
 * don't propagate quirks-mode text-decoration across HTML table elements, to fix this bug (and compat with WebKit (mostly, though it also does the same for display:table) and IE)
 * don't propagate quirks-mode text-decoration across inline-block and inline-table, to match spec and WebKit

I'm also setting up the quirks-mode code to be usable for all modes.  This means that I make the first of the above two fixes conditioned on quirks mode but the second apply to all modes, and additionally add a standards-mode check for floating and abs-pos to match the spec's propagation rules.
(Assignee)

Comment 28

7 years ago
Created attachment 491983 [details] [diff] [review]
patch

See comment 27 for explanation.
Attachment #491983 - Flags: review?(roc)
Attachment #491983 - Flags: review?(roc) → review+
(Assignee)

Comment 29

7 years ago
http://hg.mozilla.org/mozilla-central/rev/4847e1cf6cf4
Status: NEW → RESOLVED
Last Resolved: 7 years ago
OS: Windows 7 → All
Priority: -- → P3
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
(Assignee)

Updated

6 years ago
Blocks: 224633
You need to log in before you can comment on or make changes to this bug.