Closed
Bug 572811
Opened 14 years ago
Closed 14 years ago
Make force build and rebuild options in buildbot work for try builds
Categories
(Release Engineering :: General, enhancement, P5)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: lsblakk, Assigned: lsblakk)
References
Details
(Whiteboard: [tryserver])
Attachments
(1 file)
1004 bytes,
patch
|
catlee
:
review+
lsblakk
:
checked-in+
|
Details | Diff | Splinter Review |
Right now we can work around by inputting the 'who' and 'revision' properties, but it would be great to do it from the buildbot page.
Comment 1•14 years ago
|
||
Actually we can't work around it right now. We need to update the code to check for a pre-existing 'who' property for this to work.
Comment 3•14 years ago
|
||
So this _does_ work on a standalone master (builders and schedulers in the same instance). Maybe it's fixed now? Or maybe unique to running builders separate from schedulers?
Assignee | ||
Comment 5•14 years ago
|
||
It does work both in the self-serve via db and in the try waterfall on force rebuild now that we don't set who via parse_email, in fact that little function can be removed, and we get who from build.source.changes[0].who
We can resolve this fixed once the parse_email patch lands just for cleanliness.
Attachment #511911 -
Flags: review?(catlee)
Updated•14 years ago
|
Attachment #511911 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 6•14 years ago
|
||
Comment on attachment 511911 [details] [diff] [review]
remove parse_email from process/factory.py
landed: http://hg.mozilla.org/build/buildbotcustom/rev/1946643325e2
Attachment #511911 -
Flags: checked-in+
Assignee | ||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•