572900 - Remove cruft that's not needed after landing of bug 564991

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

A bunch of code is simply not used anymore, especially related to scrolling. E.g. nsIWidget::Scroll will be dead.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 1: Remove view cruft that's not needed now that scrolling is layer-based

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(These patches depend on all the patches in bug 564991, including some I haven't attached yet.)

Comment 3

[Timothy Nikkel (:tnikkel)]

Is nsPresContext::NotifyInvalidateForScrolling still needed? I ask because it would need changes for bug 563878 if it needs to remain.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

No, it's not called anymore.

Comment 5

[Timothy Nikkel (:tnikkel)]

Can we kill it too then? Or do you have plans to use it again?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We should kill it.

Comment 7

[Timothy Nikkel (:tnikkel)]

Do you want me to submit a patch or do you want to do it?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Either's fine

Comment 9

[Timothy Nikkel (:tnikkel)]

Attachment: Part 2. Get rid of nsPresContext::NotifyInvalidateForScrolling.

Can you stick this in your layers patch queue to be landed with the rest?

Comment 10

[Timothy Nikkel (:tnikkel)]

Attachment: Part 2. Get rid of nsPresContext::NotifyInvalidateForScrolling.

Oops, forget something.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I actually want to keep patches out of my layers patch queue that aren't needed to land retained layers, so if you don't mind I'll leave your patch out.

Comment 12

[Timothy Nikkel (:tnikkel)]

Oh, this is required to land, I thought it was just a clean up bug.

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Part 1 is in my queue just because I did it and then put some other stuff on top of it that *is* required to land.

Comment 14

[Timothy Nikkel (:tnikkel)]

Comment on attachment 453653 [details] [diff] [review]
Part 2. Get rid of nsPresContext::NotifyInvalidateForScrolling.

Then we'll do this somewhere else.

Comment 15

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/751e74792a2f