Closed Bug 572900 Opened 11 years ago Closed 11 years ago

Remove cruft that's not needed after landing of bug 564991

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(1 file, 2 obsolete files)

A bunch of code is simply not used anymore, especially related to scrolling. E.g. nsIWidget::Scroll will be dead.
(These patches depend on all the patches in bug 564991, including some I haven't attached yet.)
Is nsPresContext::NotifyInvalidateForScrolling still needed? I ask because it would need changes for bug 563878 if it needs to remain.
No, it's not called anymore.
Can we kill it too then? Or do you have plans to use it again?
Do you want me to submit a patch or do you want to do it?
Can you stick this in your layers patch queue to be landed with the rest?
Attachment #453652 - Flags: review?(roc)
Oops, forget something.
Attachment #453652 - Attachment is obsolete: true
Attachment #453653 - Flags: review?(roc)
Attachment #453652 - Flags: review?(roc)
I actually want to keep patches out of my layers patch queue that aren't needed to land retained layers, so if you don't mind I'll leave your patch out.
Oh, this is required to land, I thought it was just a clean up bug.
Part 1 is in my queue just because I did it and then put some other stuff on top of it that *is* required to land.
Comment on attachment 453653 [details] [diff] [review]
Part 2. Get rid of nsPresContext::NotifyInvalidateForScrolling.

Then we'll do this somewhere else.
Attachment #453653 - Attachment is obsolete: true
Attachment #453653 - Flags: review?(roc)
Attachment #452129 - Flags: review?(tnikkel) → review+
http://hg.mozilla.org/mozilla-central/rev/751e74792a2f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.