1.69 KB, text/html
491 bytes, text/html
1.01 KB, text/html
781 bytes, patch
Alexandru Savulov: review+
Marc Attinasi: superreview+
|Details | Diff | Splinter Review|
using 10/19 build of netscape 1) launch netscape 2) launch composer 3) insert default table 2 x 2 4) click in any cell 5) bring up Cell Props 6) change the cell height parameter to anything(pixel or %) 7) click OK on the panel nothing happens no matter what value(pixel or %) you choose, nothing happens. Cell height remains unchanged. all platforms.
Sujay, if you enter several lines of text in row1,cell1 and then enter 1 line of text in row1, cell2 and then adjust the cell height what happens?
I tried that Beth.... also I displayed in the browser and don't see the cell height changes reflected. could be a layout bug...
ok, the pixel selection works -- see the attached test case. The % value works as long as there is a % value in the table properties sheet. If the table height value is blank, then the % value is not responding, which kind of make sense. But, if the table height value must have content, then there should be an indicator that that must be set. Moving this over to mozilla0.9
Cell height should never be a % number. Cell height and width are depracated in HTML4. We should remove the width and height options from the cell tab.
patches are attached to bug #56139: http://bugzilla.mozilla.org/showattachment.cgi?attach_id=18129 http://bugzilla.mozilla.org/showattachment.cgi?attach_id=18130
ok; an informal poll of people resulted in a decision that we will allow users to set the width of a cell (but not the height) from the dialog. I will develop new patches and attach them here.
The new patch for this bug is at: http://bugzilla.mozilla.org/showattachment.cgi?attach_id=19152 fixing subject since we only intend to remove cell height at this time.
hmmm... the intent is to support both width and height via CSS in the future so I guess we'll leave both of these options in after all. Ignore all previous comments regarding patches for this bug. The original problem with cell height not working if it's a %age remains a valid issue.
reassign to karnaze; this seems to be a layout bug (sorry about my earlier (incorrect) comments; they were based on an old version of the HTML 4 spec)
Moving to m0.9.1.
Moving to m0.9.3
Created attachment 43155 [details] Test for percentage heights on table cells (ignore previous attachment)
This shows we do as well as WinIE on cell heights that are percentages, but not as well for row heights (although we do better than Nav4 for row heights and the same as MacIE5).
reassigning to m0.9.6
We layout the 1st attachment like IE. When there are conflicting pixel and percent cell heights within a row, the highest percent value is used (but will not be honored if the table has no height). The patch fixes the <tr height=50%> in the 3rd table of the 3rd attachment.
Comment on attachment 56679 [details] [diff] [review] patch to honor height attribute on a row r= alexsavulov
Comment on attachment 56679 [details] [diff] [review] patch to honor height attribute on a row sr=attinasi
The patch is in.