percentage row heights behave differently from WinIE

RESOLVED FIXED in mozilla0.9.6

Status

()

Core
Layout: Tables
P3
normal
RESOLVED FIXED
17 years ago
16 years ago

People

(Reporter: sujay, Assigned: karnaze (gone))

Tracking

({testcase})

Trunk
mozilla0.9.6
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [awd:tbl]PATCH CANDIDATE_094)

Attachments

(4 attachments)

(Reporter)

Description

17 years ago
using 10/19 build of netscape

1) launch netscape
2) launch composer
3) insert default table 2 x 2
4) click in any cell
5) bring up Cell Props
6) change the cell height parameter to anything(pixel or %)
7) click OK on the panel

nothing happens

no matter what value(pixel or %) you choose, nothing happens. Cell height
remains unchanged.

all platforms.

Comment 1

17 years ago
Sujay, if you enter several lines of text in row1,cell1 and then enter 1 line of
text in row1, cell2 and then adjust the cell height what happens?
(Reporter)

Comment 2

17 years ago
I tried that Beth....

also I displayed in the browser and don't see the cell height changes reflected.

could be a layout bug...

Comment 3

17 years ago
Created attachment 17836 [details]
sample table for cell height in pixels

Comment 4

17 years ago
ok, the pixel selection works -- see the attached test case. The % value works
as long as there is a % value in the table properties sheet. If the table height
value is blank, then the % value is not responding, which kind of make sense.
But, if the table height value must have content, then there should be an
indicator that that must be set. Moving this over to mozilla0.9
Target Milestone: --- → mozilla0.9

Comment 5

17 years ago
Cell height should never be a % number.
Cell height and width are depracated in HTML4.
We should remove the width and height options from the cell tab.
Status: NEW → ASSIGNED
Summary: cell height props doesn't do anything → cell height and width shouldn't be offered in props

Comment 6

17 years ago
patches are attached to bug #56139:
  http://bugzilla.mozilla.org/showattachment.cgi?attach_id=18129
  http://bugzilla.mozilla.org/showattachment.cgi?attach_id=18130
Summary: cell height and width shouldn't be offered in props → cell height & width shouldn't be offered in properties dlog
Whiteboard: links to patches in description

Comment 7

17 years ago
ok; an informal poll of people resulted in a decision that we will allow users
to set the width of a cell (but not the height) from the dialog.  I will develop
new patches and attach them here.

Comment 8

17 years ago
The new patch for this bug is at:
  http://bugzilla.mozilla.org/showattachment.cgi?attach_id=19152

fixing subject since we only intend to remove cell height at this time.
Summary: cell height & width shouldn't be offered in properties dlog → cell height shouldn't be offered in properties dlog

Comment 9

17 years ago
hmmm... the intent is to support both width and height via CSS in the future so
I guess we'll leave both of these options in after all.  Ignore all previous
comments regarding patches for this bug.  The original problem with cell height
not working if it's a %age remains a valid issue.
Summary: cell height shouldn't be offered in properties dlog → cell height doesn't render properly if it's a percentage (%)
Whiteboard: links to patches in description

Comment 10

17 years ago
reassign to karnaze; this seems to be a layout bug

(sorry about my earlier (incorrect) comments; they were based on an old version
of the HTML 4 spec)
Assignee: brade → karnaze
Status: ASSIGNED → NEW
Component: Editor → Layout
(Assignee)

Comment 11

17 years ago
Moving to m0.9.1.
Target Milestone: mozilla0.9 → mozilla0.9.1
(Assignee)

Comment 12

17 years ago
Moving to m0.9.3
Target Milestone: mozilla0.9.1 → mozilla0.9.3
Created attachment 43154 [details]
Test for percentage heights on table cells.
Created attachment 43155 [details]
Test for percentage heights on table cells (ignore previous attachment)
This shows we do as well as WinIE on cell heights that are percentages, but not 
as well for row heights (although we do better than Nav4 for row heights and 
the same as MacIE5).
Summary: cell height doesn't render properly if it's a percentage (%) → percentage row heights behave differently from WinIE

Comment 16

17 years ago
Missed 0.9.3.
Target Milestone: mozilla0.9.3 → mozilla0.9.4
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9.4 → mozilla0.9.5

Updated

17 years ago
Blocks: 97138
(Assignee)

Comment 17

16 years ago
reassigning to m0.9.6
Target Milestone: mozilla0.9.5 → mozilla0.9.6

Updated

16 years ago
Component: Layout → HTMLTables
Whiteboard: [awd:tbl]
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 18

16 years ago
Created attachment 56679 [details] [diff] [review]
patch to honor height attribute on a row
(Assignee)

Comment 19

16 years ago
We layout the 1st attachment like IE. When there are conflicting pixel and 
percent cell heights within a row, the highest percent value is used (but will 
not be honored if the table has no height). The patch fixes the <tr height=50%> 
in the 3rd table of the 3rd attachment.  
Keywords: testcase
Whiteboard: [awd:tbl] → [awd:tbl]PATCH

Comment 20

16 years ago
Comment on attachment 56679 [details] [diff] [review]
patch to honor height attribute on a row

r= alexsavulov
Attachment #56679 - Flags: review+

Comment 21

16 years ago
Comment on attachment 56679 [details] [diff] [review]
patch to honor height attribute on a row

sr=attinasi
Attachment #56679 - Flags: superreview+
(Assignee)

Comment 22

16 years ago
The patch is in.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Whiteboard: [awd:tbl]PATCH → [awd:tbl]PATCH CANDIDATE_094
You need to log in before you can comment on or make changes to this bug.