Closed Bug 573060 Opened 13 years ago Closed 13 years ago

TM: move the cycle collector out of the JS GC callback

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Version:
Other Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: gal, Assigned: gal)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

patch
3.71 KB, patch
peterv
: review+
Details | Diff | Splinter Review 
There is no longer a need for the JS GC and the cycle collector to dance around each other in lock-step, so we should be able to do the JS GC first, and then the cycle collection.
Depends on: 549806
Blocks: 565217
Attached patch patch — — Splinter Review 
Assignee: general → gal

    
  

        Attachment #452288 -
        Flags: review?(peterv)

    
    

    
  
With this patch the JS GC completes first (mark + sweep) and then the CC runs (model building + cycle breaking). We don't seem to leak (fingers crossed). Looks good so far.

    
  
Blocks: 573175

    
    

    
  
Review ping. Blocks the rest of my CC patch queue.

    
    

    
  
Review ping. I need to land this soon, it blocks a bunch of GC refactoring work.

        Attachment #452288 -
        Flags: review?(peterv) → review+

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/0d9c80fde27f
Whiteboard: fixed-in-tracemonkey

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/c3f993cb1bfb
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.