Closed
Bug 573060
Opened 14 years ago
Closed 14 years ago
TM: move the cycle collector out of the JS GC callback
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gal, Assigned: gal)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
3.71 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
There is no longer a need for the JS GC and the cycle collector to dance around each other in lock-step, so we should be able to do the JS GC first, and then the cycle collection.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: general → gal
|
|
Assignee | |
Updated•14 years ago
|
Attachment #452288 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 2•14 years ago
|
||
With this patch the JS GC completes first (mark + sweep) and then the CC runs (model building + cycle breaking). We don't seem to leak (fingers crossed). Looks good so far.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Review ping. Blocks the rest of my CC patch queue.
|
|
Assignee | |
Comment 4•14 years ago
|
||
Review ping. I need to land this soon, it blocks a bunch of GC refactoring work.
|
||
Updated•14 years ago
|
Attachment #452288 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/0d9c80fde27f
Whiteboard: fixed-in-tracemonkey
|
|
Assignee | |
Comment 6•14 years ago
|
||
re-landed: http://hg.mozilla.org/tracemonkey/rev/c3f993cb1bfb
|
||
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c3f993cb1bfb
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•