Closed Bug 573066 Opened 10 years ago Closed 10 years ago
Fix ctypes stdcall closure tests
The stdcall closure tests aren't that happy on Windows due to a libffi bug or two. I have some patches which I need to tidy up and push upstream; after which we can pull the new libffi rev and re-enable the tests.
This is the libffi fix: adds X86_ANY to indicate any x86 platform, and then makes the stack calculation code not count space for the return value twice. Pushing upstream...
Pretty self-explanatory. ;)
Attachment #462958 - Flags: review?(benjamin)
Comment on attachment 462957 [details] [diff] [review] add X86_ANY Looking for rs= here. (Though if it doesn't get upstreamed soon, we'll carry it locally.)
Attachment #462957 - Flags: review?(benjamin)
This should block; the patch has been taken upstream so I just need to pull in libffi git head and enable the test.
blocking2.0: --- → ?
http://hg.mozilla.org/tracemonkey/rev/af3cf4beaa0a ... aaand we're all done fixing stdcall!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.