Fix ctypes stdcall closure tests

RESOLVED FIXED

Status

()

Core
js-ctypes
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: dwitte@gmail.com, Assigned: dwitte@gmail.com)

Tracking

unspecified
x86
Linux
Points:
---

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
The stdcall closure tests aren't that happy on Windows due to a libffi bug or two. I have some patches which I need to tidy up and push upstream; after which we can pull the new libffi rev and re-enable the tests.
(Assignee)

Comment 1

7 years ago
Created attachment 462957 [details] [diff] [review]
add X86_ANY

This is the libffi fix: adds X86_ANY to indicate any x86 platform, and then makes the stack calculation code not count space for the return value twice. Pushing upstream...
(Assignee)

Comment 2

7 years ago
Created attachment 462958 [details] [diff] [review]
uncomment closure tests

Pretty self-explanatory. ;)
Attachment #462958 - Flags: review?(benjamin)
(Assignee)

Comment 3

7 years ago
Comment on attachment 462957 [details] [diff] [review]
add X86_ANY

Looking for rs= here. (Though if it doesn't get upstreamed soon, we'll carry it
locally.)
Attachment #462957 - Flags: review?(benjamin)
Attachment #462957 - Flags: review?(benjamin) → review+
Attachment #462958 - Flags: review?(benjamin) → review+
(Assignee)

Comment 4

7 years ago
This should block; the patch has been taken upstream so I just need to pull in libffi git head and enable the test.
blocking2.0: --- → ?
blocking2.0: ? → betaN+
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/tracemonkey/rev/af3cf4beaa0a

... aaand we're all done fixing stdcall!
Whiteboard: fixed-in-tracemonkey

Comment 6

7 years ago
http://hg.mozilla.org/mozilla-central/rev/af3cf4beaa0a
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.