Closed
Bug 573092
Opened 14 years ago
Closed 14 years ago
[Win] Crash in [@ nsXREDirProvider::DoStartup() ]
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b1
People
(Reporter: marcia, Assigned: benedict)
Details
(Keywords: crash)
Crash Data
Attachments
(2 files, 1 obsolete file)
|
1.22 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
|
917 bytes,
patch
|
Details | Diff | Splinter Review |
Seen while reviewing trunk crash data. Currently #14 top crash on the trunk. Crashes started around 6/12 and spiked on 6/16. http://tinyurl.com/29me3nb links to all crashes. Many are startup crashes with little uptime. Frame Module Signature [Expand] Source 0 xul.dll nsXREDirProvider::DoStartup toolkit/xre/nsXREDirProvider.cpp:819 1 xul.dll XRE_main toolkit/xre/nsAppRunner.cpp:3485 2 firefox.exe wmain toolkit/xre/nsWindowsWMain.cpp:120 3 firefox.exe __tmainCRTStartup obj-firefox/memory/jemalloc/crtsrc/crtexe.c:591 4 kernel32.dll BaseProcessStart
|
Assignee | |
Comment 1•14 years ago
|
||
Not sure how to reproduce this, but seems likely that the AddsonManager doesn't get created, so derefing causes a crash. Mossop says it is okay to ignore failed AddsonManager creation and continue with startup, which is what this patch does.
|
||
Comment 2•14 years ago
|
||
YOu could reproduce it by deleting the extension manager component
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 452327 [details] [diff] [review] Adds null-check in nsXREDirProvider during startup Can you get the nsresult here and log that?
|
|
Assignee | |
Comment 4•14 years ago
|
||
NS_WARNING prints the nsresult now.
Attachment #452327 -
Attachment is obsolete: true
Attachment #452358 -
Flags: review?(dtownsend)
Attachment #452327 -
Flags: review?(dtownsend)
|
|
Assignee | |
Comment 5•14 years ago
|
||
Triggers a OOM error when AddonsManager is requested, I used this to (kind of) reproduce and test the fix.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #452359 -
Attachment is patch: true
Attachment #452359 -
Attachment mime type: application/octet-stream → text/plain
|
|
||
Comment 6•14 years ago
|
||
Comment on attachment 452327 [details] [diff] [review] Adds null-check in nsXREDirProvider during startup Sorry, that turned out to be more complex to do than I had anticipated. Let's just stick with the basic version for now.
Attachment #452327 -
Attachment is obsolete: false
Attachment #452327 -
Flags: review+
|
|
||
Updated•14 years ago
|
Attachment #452358 -
Attachment is obsolete: true
Attachment #452358 -
Flags: review?(dtownsend)
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
||
Comment 7•14 years ago
|
||
Landed: http://hg.mozilla.org/mozilla-central/rev/44ad97ab786f
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Flags: in-litmus-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a6
|
||
Updated•13 years ago
|
Crash Signature: [@ nsXREDirProvider::DoStartup() ]
You need to log in
before you can comment on or make changes to this bug.
Description
•