573127 - "ASSERTION: Why did this not get handled while processing mRestyleRoots?" with mathvariant

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jesse Ruderman]

Attachment: testcase

There are lots of ways to trigger this assertion.  I have semi-reduced testcases for lots of them.

###!!! ASSERTION: Why did this not get handled while processing mRestyleRoots?: '!element->HasFlag(collector->tracker->RootBit()) || (element->GetFlattenedTreeParent() && !element->GetFlattenedTreeParent()->GetPrimaryFrame()) || (aData.mChangeHint & nsChangeHint_ReconstructFrame)', file /builds/slave/mozilla-central-macosx-debug/build/layout/base/RestyleTracker.cpp, line 114

Comment 1

[Boris Zbarsky [:bzbarsky]]

Certainly mine.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yeah, ok.  The assert needs a small adjustment to make it match reality.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 452414 [details] [diff] [review]
Like so

r=dbaron, though it's getting to be a pretty confusing assertion

Comment 5

[Boris Zbarsky [:bzbarsky]]

Yeah, the problem is it's trying to catch cases when flags would be removed "incorrectly", and those cases are complicated.  :(

Comment 6

[Boris Zbarsky [:bzbarsky]]

Pushed:

  http://hg.mozilla.org/mozilla-central/rev/13a9aecb404f
  http://hg.mozilla.org/mozilla-central/rev/fe16c033cfa7