573225 - Master Password prompt textbox labeled with "Password:"

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Bobby Johnson [:rjohnson19]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100619 Minefield/3.7a6pre Firefox/3.6.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100619 Minefield/3.7a6pre

The Master Password prompt now has the textbox for password entry labeled with "Password:"
This was not the case at most a week or two ago.

Reproducible: Always

Steps to Reproduce:
1. Set a Master Password
2. Trigger a master password prompt, by visiting a site with a saved login or viewing Saved Passwords 
(Tools -> Options -> Security -> Saved Passwods, Show Passwords button).
Actual Results:  
Master Password textbox labeled with "Password:".

Expected Results:  
Master password prompt appears with no labeling text to the left of the textbox.

A nightly tester on Linux confirmed they see this: http://forums.mozillazine.org/viewtopic.php?p=9511529#p9511529

Comment 1

[Bobby Johnson [:rjohnson19]]

Attachment: Screenshot of a master password prompt

Comment 2

[Justin Dolske [:Dolske]]

PSM's callback use nsIPrompt::PromptPassword. The old code (prior to bug 563274) cleared the password textbox's label when it was the only textbox in the dialog.

This behavior wasn't retained, but I don't think I did it deliberately. There's already code in the prompt() case to drop the "Username:" label, we should probably just do the same here.

See earlyInit() in http://mxr.mozilla.org/mozilla-central/source/toolkit/components/prompts/content/commonDialog.js

Comment 3

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 452797 [details] [diff] [review]
Patch v.1

I thought we both agreed in bug 563274 comment 17 (search for "Not intentional") that this was an OK behavior change. I don't really see why the label is a problem, but I don't particularly care about it being there either, so if we want to revert that's fine too, I guess!

Comment 5

[Justin Dolske [:Dolske]]

Oh, heh, we did. I don't think it's a big deal either way, though I guess I'm slightly influenced by having had someone notice this change within a couple days of it landing.

Comment 6

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/05a7f02a1fec