573302 - Folder name is not updated when creating a folder and/or editing name in Properties

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100619 Minefield/3.7a6pre ID:20100619040308
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100619 Minefield/3.7a6pre ID:20100619040308

This happens only in "Bookmarks" menu,

Folder name does not update after create a folder into "Bookmarks" menu, the name of folder is[Folder Name] not a edited name.
And folder name does not update after edit name in "Properties" dialog.

After restart Browser the name folder is updated properly.

Reproducible: Always

Steps to Reproduce 1:
1. Start Minefield with new profile
2. "Bookmarks" > right click on any bookmark > Choose "New Folder..."
3. Edit folder name in "Name" field.and Click "Add".
4. Open "Bookmarks" menu  and you see 

Steps to Reproduce 2:
1. Start Minefield with new profile
2. Open 2-3 tabs with defferent URL
2. Right click on tab strip. And Choose "Bookmark All Tabs..."
3. Edit folder name in "Name" field.and Click "Add Bookmarks".
4. Open "Bookmarks" menu  and you see 

Actual Results:
 The created folder name appears as "Folder Name"

Expected Results:
 The created folder name should appears as a edited name.

Steps to Reproduce 3:
1. Start Minefield with new profile
2. "Bookmarks" > right click on a folder > Choose "Properties"
3. Edit folder name in "Name" field.And click "Save".
4. Open "Bookmarks" menu  and you see 

Actual Results:
 The folder name is not updated

Expected Results:
 The folder name should be updated

Regression Window:

Works:
http://hg.mozilla.org/mozilla-central/rev/00955067e4b5
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100504 Minefield/3.7a5pre ID:20100505053644

Fails:
http://hg.mozilla.org/mozilla-central/rev/d7393e28fb2d
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100504 Minefield/3.7a5pre ID:20100505071655

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=00955067e4b5&tochange=d7393e28fb2d

Comment 1

[Alice0775 White]

Rebert to 11a25fc022ba in local build, then the problem does not happen.
Landing a patch of Bug 528884 causes the problem.

Comment 2

[Alice0775 White]

In adittion to comment#0
This happens chevron's popup also.

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch v1.0

If prefer if this handler passes through the base view impl, even if that means duplicating a couple ifs.

The tests could probably be written in a more clear fashion, but it's not a priority atm, it just works.

There are also a couple fixes for js and cpp warning that I saw during the test.

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/b6678d36e1a4