Closed Bug 573322 Opened 10 years ago Closed 10 years ago

Align td@align with HTML5

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b3
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

()

Details

(Keywords: html5)

Attachments

(1 file, 2 obsolete files)

HTML5 expects us to support left, right, justify, center and middle for align on td, th, tr, col, thead, tbody and tfoot, both in no quirks and quirks mode. Patch upcoming.
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #452534 - Flags: review?(jonas)
So no more absmiddle?  Is that not supported by other UAs?
Attached patch Patch v2 (obsolete) — Splinter Review
Actually, absmiddle is hidden in the CSS block above the prose, where all the other values are defined.
Attachment #452534 - Attachment is obsolete: true
Attachment #452578 - Flags: review?(bzbarsky)
Attachment #452534 - Flags: review?(jonas)
I assume comment 3 is talking about the spec, not our code?  Spec link, please?
Yeah. <http://www.whatwg.org/html/#alignment>, absmiddle is in the second CSS block, the other values are in the prose below.
OK.  So why did the code use to have "center" twice in there, and why is it ok to no longer do that?
As can be seen at <http://software.hixie.ch/utilities/js/live-dom-viewer/saved/533>, getAttribute("align") currently returns "center" instead of "absmiddle", even though those values have different effects. I don't see the point in having the reverse mapping from text-align:center (rather than text-align:-moz-center) to "center".
Comment on attachment 452578 [details] [diff] [review]
Patch v2

r=bzbarsky.  Sorry for the lag here....  Ask for approval?
Attachment #452578 - Flags: review?(bzbarsky) → review+
Attachment #452578 - Flags: approval2.0?
blocking2.0: --- → betaN+
Attachment #452578 - Flags: approval2.0?
Attachment #452578 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/664d5e6913fc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b3
You need to log in before you can comment on or make changes to this bug.