573322 - Align td@align with HTML5

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

HTML5 expects us to support left, right, justify, center and middle for align on td, th, tr, col, thead, tbody and tfoot, both in no quirks and quirks mode. Patch upcoming.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 2

[Boris Zbarsky [:bzbarsky]]

So no more absmiddle?  Is that not supported by other UAs?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

Actually, absmiddle is hidden in the CSS block above the prose, where all the other values are defined.

Comment 4

[Boris Zbarsky [:bzbarsky]]

I assume comment 3 is talking about the spec, not our code?  Spec link, please?

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Yeah. <http://www.whatwg.org/html/#alignment>, absmiddle is in the second CSS block, the other values are in the prose below.

Comment 6

[Boris Zbarsky [:bzbarsky]]

OK.  So why did the code use to have "center" twice in there, and why is it ok to no longer do that?

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

As can be seen at <http://software.hixie.ch/utilities/js/live-dom-viewer/saved/533>, getAttribute("align") currently returns "center" instead of "absmiddle", even though those values have different effects. I don't see the point in having the reverse mapping from text-align:center (rather than text-align:-moz-center) to "center".

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 452578 [details] [diff] [review]
Patch v2

r=bzbarsky.  Sorry for the lag here....  Ask for approval?

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for checkin

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/664d5e6913fc