Last Comment Bug 573322 - Align td@align with HTML5
: Align td@align with HTML5
: html5
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla2.0b3
Assigned To: :Ms2ger
Depends on:
  Show dependency treegraph
Reported: 2010-06-20 02:00 PDT by :Ms2ger
Modified: 2010-07-30 17:01 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (7.12 KB, patch)
2010-06-20 02:15 PDT, :Ms2ger
no flags Details | Diff | Splinter Review
Patch v2 (7.17 KB, patch)
2010-06-20 10:23 PDT, :Ms2ger
bzbarsky: review+
Details | Diff | Splinter Review
Patch for checkin (7.27 KB, patch)
2010-07-29 12:11 PDT, :Ms2ger
no flags Details | Diff | Splinter Review

Description :Ms2ger 2010-06-20 02:00:39 PDT
HTML5 expects us to support left, right, justify, center and middle for align on td, th, tr, col, thead, tbody and tfoot, both in no quirks and quirks mode. Patch upcoming.
Comment 1 :Ms2ger 2010-06-20 02:15:34 PDT
Created attachment 452534 [details] [diff] [review]
Patch v1
Comment 2 Boris Zbarsky [:bz] 2010-06-20 09:31:08 PDT
So no more absmiddle?  Is that not supported by other UAs?
Comment 3 :Ms2ger 2010-06-20 10:23:14 PDT
Created attachment 452578 [details] [diff] [review]
Patch v2

Actually, absmiddle is hidden in the CSS block above the prose, where all the other values are defined.
Comment 4 Boris Zbarsky [:bz] 2010-06-20 10:49:19 PDT
I assume comment 3 is talking about the spec, not our code?  Spec link, please?
Comment 5 :Ms2ger 2010-06-20 11:12:31 PDT
Yeah. <>, absmiddle is in the second CSS block, the other values are in the prose below.
Comment 6 Boris Zbarsky [:bz] 2010-07-03 00:55:34 PDT
OK.  So why did the code use to have "center" twice in there, and why is it ok to no longer do that?
Comment 7 :Ms2ger 2010-07-03 12:55:50 PDT
As can be seen at <>, getAttribute("align") currently returns "center" instead of "absmiddle", even though those values have different effects. I don't see the point in having the reverse mapping from text-align:center (rather than text-align:-moz-center) to "center".
Comment 8 Boris Zbarsky [:bz] 2010-07-28 13:04:38 PDT
Comment on attachment 452578 [details] [diff] [review]
Patch v2

r=bzbarsky.  Sorry for the lag here....  Ask for approval?
Comment 9 :Ms2ger 2010-07-29 12:11:24 PDT
Created attachment 461297 [details] [diff] [review]
Patch for checkin
Comment 10 David Baron :dbaron: ⌚️UTC+2 (review requests must explain patch) 2010-07-30 17:01:50 PDT

Note You need to log in before you can comment on or make changes to this bug.