The default bug view has changed. See this FAQ.

Align td@align with HTML5

RESOLVED FIXED in mozilla2.0b3

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

({html5})

Trunk
mozilla2.0b3
html5
Points:
---

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
HTML5 expects us to support left, right, justify, center and middle for align on td, th, tr, col, thead, tbody and tfoot, both in no quirks and quirks mode. Patch upcoming.
(Assignee)

Comment 1

7 years ago
Created attachment 452534 [details] [diff] [review]
Patch v1
Attachment #452534 - Flags: review?(jonas)
So no more absmiddle?  Is that not supported by other UAs?
(Assignee)

Comment 3

7 years ago
Created attachment 452578 [details] [diff] [review]
Patch v2

Actually, absmiddle is hidden in the CSS block above the prose, where all the other values are defined.
Attachment #452534 - Attachment is obsolete: true
Attachment #452578 - Flags: review?(bzbarsky)
Attachment #452534 - Flags: review?(jonas)
I assume comment 3 is talking about the spec, not our code?  Spec link, please?
(Assignee)

Comment 5

7 years ago
Yeah. <http://www.whatwg.org/html/#alignment>, absmiddle is in the second CSS block, the other values are in the prose below.
OK.  So why did the code use to have "center" twice in there, and why is it ok to no longer do that?
(Assignee)

Comment 7

7 years ago
As can be seen at <http://software.hixie.ch/utilities/js/live-dom-viewer/saved/533>, getAttribute("align") currently returns "center" instead of "absmiddle", even though those values have different effects. I don't see the point in having the reverse mapping from text-align:center (rather than text-align:-moz-center) to "center".
Comment on attachment 452578 [details] [diff] [review]
Patch v2

r=bzbarsky.  Sorry for the lag here....  Ask for approval?
Attachment #452578 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

7 years ago
Attachment #452578 - Flags: approval2.0?
blocking2.0: --- → betaN+
Attachment #452578 - Flags: approval2.0?
(Assignee)

Comment 9

7 years ago
Created attachment 461297 [details] [diff] [review]
Patch for checkin
Attachment #452578 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/664d5e6913fc
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b3
You need to log in before you can comment on or make changes to this bug.