The default bug view has changed. See this FAQ.

Implement the figure and figcaption elements

RESOLVED FIXED in mozilla2.0b1

Status

()

Core
DOM: Core & HTML
--
enhancement
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

({dev-doc-complete, html5})

Trunk
mozilla2.0b1
dev-doc-complete, html5
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

7 years ago
Created attachment 452564 [details] [diff] [review]
Patch v1
Attachment #452564 - Flags: review?(jst)
(Assignee)

Comment 1

7 years ago
Comment on attachment 452564 [details] [diff] [review]
Patch v1

timeless, could you review the editor parts?
Attachment #452564 - Flags: review?(timeless)

Comment 2

7 years ago
Comment on attachment 452564 [details] [diff] [review]
Patch v1

>diff --git a/content/base/src/nsGkAtomList.h b/content/base/src/nsGkAtomList.h
>+GK_ATOM(figure, "figure")
>+GK_ATOM(figcaption, "figcaption")

this isn't sorted correctly.

>diff --git a/editor/libeditor/base/nsEditPropertyAtomList.h b/editor/libeditor/base/nsEditPropertyAtomList.h
>@@ -120,16 +120,18 @@ EDITOR_ATOM(address, "address")
> EDITOR_ATOM(address, "address")
..
> EDITOR_ATOM(footer, "footer")
..
> EDITOR_ATOM(section, "section")
>+EDITOR_ATOM(figure, "figure")
>+EDITOR_ATOM(figcaption, "figcaption")

odd sorting, and what's the logic to stick this here?
(Assignee)

Updated

7 years ago
Depends on: 573377
(Assignee)

Comment 3

7 years ago
Created attachment 452590 [details] [diff] [review]
Patch v2

Now with saner sorting. Thanks, timeless
Attachment #452564 - Attachment is obsolete: true
Attachment #452590 - Flags: review?(jst)
Attachment #452564 - Flags: review?(timeless)
Attachment #452564 - Flags: review?(jst)
(Assignee)

Updated

7 years ago
Attachment #452590 - Flags: review?(timeless)

Updated

7 years ago
Attachment #452590 - Flags: review?(timeless) → review+
Comment on attachment 452590 [details] [diff] [review]
Patch v2

Looks good to me, but I'd like Ehsan to have a look at the editor changes here.
Attachment #452590 - Flags: review?(jst)
Attachment #452590 - Flags: review?(ehsan)
Attachment #452590 - Flags: review+
Comment on attachment 452590 [details] [diff] [review]
Patch v2

The figcaption element cannot contain itself.
Attachment #452590 - Flags: review?(ehsan) → review-
Which means, the third parameter to the ELEM macro should be PR_FALSE.
(Assignee)

Comment 7

7 years ago
Created attachment 452984 [details] [diff] [review]
Patch v3

Thanks, fixed that.
Attachment #452590 - Attachment is obsolete: true
Attachment #452984 - Flags: review?(ehsan)

Updated

7 years ago
Attachment #452984 - Flags: review?(ehsan) → review+
(Assignee)

Comment 8

7 years ago
Created attachment 453350 [details] [diff] [review]
Patch for checkin

r=jst+timeless+ehsan.
Attachment #452984 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Assuming this needs to be documented, so adding dev-doc-needed.

http://hg.mozilla.org/mozilla-central/rev/40de8e1a9f13
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed → dev-doc-needed
Resolution: --- → FIXED

Updated

7 years ago
Target Milestone: --- → mozilla1.9.3a6
It's not defined how MACRO(..., ) with an empty argument expands; filed bug 574078 on not doing that, CC'd the people who seem to have touched nsHTMLTagList.h recently.

Updated

7 years ago
Summary: Implement the figure element → Implement the figure and figcaption elements
Documentation added.

For the figcaption element: https://developer.mozilla.org/en/HTML/Element/figcaption
For the figure element: https://developer.mozilla.org/en/HTML/Element/figure

Both pages are linked from the relevant pages (Element, Firefox 4 for Developers, HTML5)

(If someone can change dev-doc-needed to dev-doc-complete, it would be nice)
(Assignee)

Comment 12

7 years ago
Thanks a lot!
Keywords: dev-doc-needed → dev-doc-complete
(Assignee)

Updated

7 years ago
Flags: in-testsuite+

Updated

5 years ago
Blocks: 658272
You need to log in before you can comment on or make changes to this bug.