Comment on attachment 452564 [details] [diff] [review] Patch v1 timeless, could you review the editor parts?
Comment on attachment 452564 [details] [diff] [review] Patch v1 >diff --git a/content/base/src/nsGkAtomList.h b/content/base/src/nsGkAtomList.h >+GK_ATOM(figure, "figure") >+GK_ATOM(figcaption, "figcaption") this isn't sorted correctly. >diff --git a/editor/libeditor/base/nsEditPropertyAtomList.h b/editor/libeditor/base/nsEditPropertyAtomList.h >@@ -120,16 +120,18 @@ EDITOR_ATOM(address, "address") > EDITOR_ATOM(address, "address") .. > EDITOR_ATOM(footer, "footer") .. > EDITOR_ATOM(section, "section") >+EDITOR_ATOM(figure, "figure") >+EDITOR_ATOM(figcaption, "figcaption") odd sorting, and what's the logic to stick this here?
Now with saner sorting. Thanks, timeless
Attachment #452590 - Flags: review?(timeless)
Comment on attachment 452590 [details] [diff] [review] Patch v2 Looks good to me, but I'd like Ehsan to have a look at the editor changes here.
Comment on attachment 452590 [details] [diff] [review] Patch v2 The figcaption element cannot contain itself.
Attachment #452590 - Flags: review?(ehsan) → review-
Which means, the third parameter to the ELEM macro should be PR_FALSE.
Thanks, fixed that.
Attachment #452984 - Attachment is obsolete: true
Assuming this needs to be documented, so adding dev-doc-needed. http://hg.mozilla.org/mozilla-central/rev/40de8e1a9f13
It's not defined how MACRO(..., ) with an empty argument expands; filed bug 574078 on not doing that, CC'd the people who seem to have touched nsHTMLTagList.h recently.
Summary: Implement the figure element → Implement the figure and figcaption elements
Documentation added. For the figcaption element: https://developer.mozilla.org/en/HTML/Element/figcaption For the figure element: https://developer.mozilla.org/en/HTML/Element/figure Both pages are linked from the relevant pages (Element, Firefox 4 for Developers, HTML5) (If someone can change dev-doc-needed to dev-doc-complete, it would be nice)
You need to log in before you can comment on or make changes to this bug.