Closed Bug 573357 Opened 13 years ago Closed 13 years ago

Use the HTMLElement interface for more elements


(Core :: DOM: Core & HTML, defect)

Not set





(Reporter: Ms2ger, Assigned: Ms2ger)




(Keywords: html5)


(1 file, 2 obsolete files)

Attached patch Patch v1 (obsolete) — Splinter Review
A number of elements implement the HTMLSpanElement and HTMLDivElement interfaces, while they should only implement HTMLElement. Thanks to Mounir, this is now easy to fix.
Attachment #452566 - Flags: review?(jst)
No longer blocks: 562008
Depends on: 562008
Please, don't change xmp, bug 568515 is already doing it needs more than just changing the macros. And your patch seems to depend on bug 485377.
Depends on: 485377
You also need to update content/html/content/test/test_bug389797.html
(In reply to comment #2)
> You also need to update content/html/content/test/test_bug389797.html

Oups, forget it.
Comment on attachment 452566 [details] [diff] [review]
Patch v1

For what it's worth, i'd rather remove the "HTMLElement instance" comments (in both the header file and the testcase).

I don't really see that they're explaining anything confusing.
Attachment #452566 - Flags: review?(jst) → review+
Attached patch Patch v2 (obsolete) — Splinter Review
Thanks, Mounir; I rebased over bug 568515.
Attachment #452566 - Attachment is obsolete: true
Attachment #452592 - Flags: review?(jst)
Depends on: 568515
Attachment #452592 - Flags: review?(jst)
Comment on attachment 452592 [details] [diff] [review]
Patch v2

Thanks. I'll remove the comments next time I edit those files, if that's fine with you.
Keywords: checkin-needed
Blocks: 574078
Your patch doesn't apply cleanly anymore.
Keywords: checkin-needed
Attached patch Patch v3Splinter Review
This one should apply cleanly.
Attachment #452592 - Attachment is obsolete: true
Keywords: checkin-needed
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.3
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.3 → mozilla1.9.3b2
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.