573357 - Use the HTMLElement interface for more elements

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

A number of elements implement the HTMLSpanElement and HTMLDivElement interfaces, while they should only implement HTMLElement. Thanks to Mounir, this is now easy to fix.

Comment 1

[Mounir Lamouri (:mounir)]

Please, don't change xmp, bug 568515 is already doing it needs more than just changing the macros. And your patch seems to depend on bug 485377.

Comment 2

[Mounir Lamouri (:mounir)]

You also need to update content/html/content/test/test_bug389797.html

Comment 3

[Mounir Lamouri (:mounir)]

(In reply to comment #2)
> You also need to update content/html/content/test/test_bug389797.html

Oups, forget it.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 452566 [details] [diff] [review]
Patch v1

For what it's worth, i'd rather remove the "HTMLElement instance" comments (in both the header file and the testcase).

I don't really see that they're explaining anything confusing.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

Thanks, Mounir; I rebased over bug 568515.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 452592 [details] [diff] [review]
Patch v2

Thanks. I'll remove the comments next time I edit those files, if that's fine with you.

Comment 7

[Dão Gottwald [::dao]]

Your patch doesn't apply cleanly anymore.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v3

This one should apply cleanly.

Comment 9

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/dacfa73ea420