573534 - onLinkIconAvailable takes aBrowser argument but doesn't use it

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Robert Kaiser]

onLinkIconAvailable is currently located in http://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/browser.js#3925 and called from tabbrowser, see http://mxr.mozilla.org/mozilla-central/search?string=onLinkIconAvailable - and it takes aBrowser as first argument but actually uses gBrowser and never aBrowser, so either that argument should go away (as it is in SeaMonkey) or be used - or possibly have a comment as to why it's not being used.
Or is the case WindowsPreviewPerTab.jsm the reason why we need to keep that argument?

Comment 1

[Dão Gottwald [:dao]]

The argument is bogus, the patch in bug 519216 removes it.

Comment 2

[Robert Kaiser]

(In reply to comment #1)
> The argument is bogus, the patch in bug 519216 removes it.

Ah, good, then I don't need to care that SeaMonkey doesn't have it. ;-)

Also, what about http://mxr.mozilla.org/mozilla-central/source/browser/components/wintaskbar/WindowsPreviewPerTab.jsm#543 - is that called by the same callers and need to change as well in bug 519216 then?

Comment 3

[Dão Gottwald [:dao]]

(In reply to comment #2)
> Also, what about
> http://mxr.mozilla.org/mozilla-central/source/browser/components/wintaskbar/WindowsPreviewPerTab.jsm#543
> - is that called by the same callers and need to change as well in bug 519216
> then?

No, it uses a "tabs progress listener", where the browser argument is actually expected and useful. See addProgressListener vs. addTabsProgressListener.

Comment 4

[Robert Kaiser]

Ah, OK, I'm not too good at those things, just stumbled into it because I need to do some tabbrowser stuff in bug 554908 to make other patches of mine working better. ;-)