573578 - fatvals+tracing: assert on Mochitest /js/src/xpconnect/tests/mochitest/test_bug462428.html

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Mandelin [:dmandelin]]

Assertion failure: JS_StringHasBeenInterned(str), at c:\sources\fatval\js\src\jsapi.h:309

Comment 1

[David Mandelin [:dmandelin]]

http://hg.mozilla.org/users/lwagner_mozilla.com/fatval/rev/ed42260c48fb

The cause was that jsval strings were being converted to jsids without interning. I believe this means there was actually an underlying bug before fatvals.

Comment 2

[Brendan Eich [:brendan]]

We already have JS_ValueToId in jsapi.h -- that was what should have been used by quickstubs code.

/be

Comment 3

[David Mandelin [:dmandelin]]

(In reply to comment #2)
> We already have JS_ValueToId in jsapi.h -- that was what should have been used
> by quickstubs code.
> 
> /be

Forgot about that one (which is a real duh--I've had to use it with other recent bugs here). I'll reopen until it's fixed the right way.

Comment 4

[David Mandelin [:dmandelin]]

Luke picked up the API fixup when doing some other fixes.