573604 - tracing+fatvals: Add AccSet parameter to box_value

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Mandelin [:dmandelin]]

Per Nick, the AccSet argument should be explicit so that callers can provide the right one.

Comment 1

[Luke Wagner [:luke]]

I misread some code and thought this might actually be a bug, but I was confusing the v_ins and dstaddr_ins arguments of box_value.  Anyhow, I did make the change, even though, as I see it, all callers currently pass ACC_OTHER.

http://hg.mozilla.org/users/lwagner_mozilla.com/fatval/rev/7cb07ed9a5bc

Comment 2

[Nicholas Nethercote [inactive]]

(In reply to comment #1)
> Anyhow, I did make
> the change, even though, as I see it, all callers currently pass ACC_OTHER.

Yes, that's right;  this change is just about making new bugs harder to create in the future.

Comment 3

[Nicholas Nethercote [inactive]]

I just noticed that box_value() is overloaded.  The second version should also have an AccSet.

Comment 4

[Nicholas Nethercote [inactive]]

(In reply to comment #3)
> I just noticed that box_value() is overloaded.  The second version should also
> have an AccSet.

That's subsumed by bug 584279.