add jdk6/bin to the step's PATH environment to workaround a make issue

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: bear, Assigned: bear)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 452914 [details] [diff] [review]
add jdk6 bin/ to PATH for compile step

add to the compile step's environment PATH value the /tools/jdk6/bin path to allow the SUTAgent build to work until they fix their issue
(Assignee)

Updated

8 years ago
Attachment #452914 - Attachment is patch: true
Attachment #452914 - Attachment mime type: application/octet-stream → text/plain
Attachment #452914 - Flags: review?(aki)
(Assignee)

Updated

8 years ago
Blocks: 567945
(Assignee)

Updated

8 years ago
Blocks: 571571

Comment 1

8 years ago
Comment on attachment 452914 [details] [diff] [review]
add jdk6 bin/ to PATH for compile step

wish i knew why java_home wasn't working, but i'm not going to block builds on that.
Attachment #452914 - Flags: review?(aki) → review+

Comment 2

8 years ago
Comment on attachment 452914 [details] [diff] [review]
add jdk6 bin/ to PATH for compile step

http://hg.mozilla.org/build/buildbotcustom/rev/3d93f905a060
Attachment #452914 - Flags: checked-in+
(Assignee)

Updated

8 years ago
No longer blocks: 571571
(Assignee)

Comment 3

8 years ago
Created attachment 452964 [details] [diff] [review]
seems you do need a default param for the get() call for path
Attachment #452964 - Flags: review?(aki)
(Assignee)

Updated

8 years ago
Attachment #452964 - Flags: review?(aki) → review?(jhford)
Comment on attachment 452964 [details] [diff] [review]
seems you do need a default param for the get() call for path

>-        envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH')
>+        envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH', os.environ['PATH'])

while we use the same ref image for the slave and master, we should not be pulling the environment of the master to set up the environment of the slave.  Instead, could we set the path explicitly in mobile_config.py?
Attachment #452964 - Flags: review?(jhford) → review-
(Assignee)

Comment 5

8 years ago
Created attachment 452972 [details] [diff] [review]
seems you do need a default param for the get() call for path
Assignee: nobody → bear
Attachment #452964 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #452972 - Flags: review?(jhford)
Comment on attachment 452972 [details] [diff] [review]
seems you do need a default param for the get() call for path

>-        envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH')
>+        envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH', '/opt/local/bin:/tools/python/bin:/tools/buildbot/bin:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin:/home/cltbld/bin'])

Assuming that bin']) should have been bin').  If that is the case, will land with this :)
Attachment #452972 - Flags: review?(jhford) → review+
(Assignee)

Comment 7

8 years ago
(In reply to comment #6)
> (From update of attachment 452972 [details] [diff] [review])
> >-        envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH')
> >+        envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH', '/opt/local/bin:/tools/python/bin:/tools/buildbot/bin:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin:/home/cltbld/bin'])
> 
> Assuming that bin']) should have been bin').  If that is the case, will land
> with this :)

yes, was too busy arguing with you to notice the errant key - thanks

Comment 8

8 years ago
Resolved?
(Assignee)

Comment 9

8 years ago
yes
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.