573672 - Use getDefaultFileName in an e10s-safe way

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

We currently pass the browser.contentDocument into getDefaultFileName - Bad for e10s. Internally, getDefaultFileName just uses the document.title property to create a nice filename.

We can do the same thing by passing .contentTitle is as a possible default and then apply the same regex.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 452977 [details] [diff] [review]
patch

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js
>     let browser = Browser.selectedBrowser;
>-    let fileName = getDefaultFileName(null, browser.documentURI, browser.contentDocument, null);
>+    let fileName = getDefaultFileName(browser.contentTitle, browser.documentURI, null, null);
>+    fileName = fileName.replace(/^\s+|\s+$/g, "");
> #ifdef MOZ_PLATFORM_MAEMO

Maybe a little comment explaining why we're doing the regexp after could be useful, not sure others will understand otherwise.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with comments:
http://hg.mozilla.org/mobile-browser/rev/e9f1b9d688e3

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #1)
> >+    fileName = fileName.replace(/^\s+|\s+$/g, "");

fileName.trim() ?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #3)
> (In reply to comment #1)
> > >+    fileName = fileName.replace(/^\s+|\s+$/g, "");
> 
> fileName.trim() ?

Yeah. I was just blindly copynig what getDefaultFileName does.

I'll fix this in an upcoming checkin

Comment 5

[Dão Gottwald [:dao]]

bugspam