573679 - Fix tests to pass on trunk

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Ed Lee :Mardak]

Bug 531151 made setPageAnnotation more robust:
test_utils_anno:	FAIL
0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIAnnotationService.setPageAnnotation]

Comment 1

[Ed Lee :Mardak]

http://hg.mozilla.org/services/fx-sync/rev/e5316053054e
Create a bookmark so that the url will exist when setting annotations.

Comment 2

[Ed Lee :Mardak]

philiKON points out httpd harness will likely be different

Comment 3

[Ed Lee :Mardak]

After fixing up some httpd stuff, there's still 12 tests failing.

Some are failing after crypto when comparing strings ?

test_clients_escape.js nsTDependentString must wrap only null-terminated strings
test_crypto_crypt.js nsTDependentString must wrap only null-terminated strings
test_records_crypto.js nsTDependentString must wrap only null-terminated strings

Some are failing when it findLogins or does stuff with the login manager ?

test_service_changePassword.js:52 this._storage is null
test_service_cluster this._storage is null
test_service_persistLogin.js:37 this._storage is null

Some have the wrong error codes ?

test_service_login.js:52 error.login.reason.no_username == error.login.reason.no_passphrase
test_service_verifyLogin.js:45 error.login.failed == service.client_not_configured

Some are test harness differences ?

test_syncengine_sync.js -> head_helper btoa
test_utils_lazySvc.js:15 obj.prof
test_utils_queryAsync.js:10 setTimeout
test_utils_stackTrace.js path munging



Here's the lines just before the assertion in test_crypto_crypt:

TEST-PASS | /Users/Ed/sync-trunk/objdir/_tests/xpcshell/test_services_sync/unit/test_crypto_crypt.js | [run_test : 22] bacon is a vegetable == bacon is a vegetable
TEST-PASS | /Users/Ed/sync-trunk/objdir/_tests/xpcshell/test_services_sync/unit/test_crypto_crypt.js | [run_test : 23] sbvqY2Bv9ayn93XbHW1C29vpApg+b39PwPeCKf6u3+s= != bacon is a vegetable
2010-06-22 12:55:59	run_test             INFO	Decrypting the record
###!!! ASSERTION: nsTDependentString must wrap only null-terminated strings: 'mData[mLength] == 0', file ../../dist/include/nsTDependentString.h, line 67
nsDependentString::AssertValid()+0x000000CF [/Users/Ed/sync-trunk/objdir/dist/bin/XUL +0x003E2C0F]
nsDependentString::nsDependentString(unsigned short const*, unsigned int)+0x00000033 [/Users/Ed/sync-trunk/objdir/dist/bin/XUL +0x00025909]
XPCConvert::JSData2Native(XPCCallContext&, void*, long, nsXPTType const&, int, nsID const*, unsigned int*)+0x000010AD [/Users/Ed/sync-trunk/objdir/dist/bin/XUL +0x00DBB2A3]
nsXPCWrappedJSClass::CallMethod(nsXPCWrappedJS*, unsigned short, XPTMethodDescriptor const*, nsXPTCMiniVariant*)+0x00001AA6 [/Users/Ed/sync-trunk/objdir/dist/bin/XUL +0x00DDA98A]
nsXPCWrappedJS::CallMethod(unsigned short, XPTMethodDescriptor const*, nsXPTCMiniVariant*)+0x00000061 [/Users/Ed/sync-trunk/objdir/dist/bin/XUL +0x00DD129F]
PrepareAndDispatch(nsXPTCStubBase*, unsigned int, unsigned int*)+0x0000027A [/Users/Ed/sync-trunk/objdir/dist/bin/XUL +0x01480024]
nsXPTCStubBase::Stub8()+0x00000035 [/Users/Ed/sync-trunk/objdir/dist/bin/XUL +0x0147AD01]
NS_InvokeByIndex_P+0x00000063 [/Users/Ed/sync-trunk/objdir/dist/bin/XUL +0x0147AAE5]
CallMethodHelper::Invoke()+0x00000070 [/Users/Ed/sync-trunk/objdir/dist/bin/XUL +0x00DEA02E]
CallMethodHelper::Call()+0x0000012C [/Users/Ed/sync-trunk/objdir/dist/bin/XUL +0x00DEC660]
XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode)+0x0000033D [/Users/Ed/sync-trunk/objdir/dist/bin/XUL +0x00DE685F]
XPC_WN_CallMethod(JSContext*, JSObject*, unsigned int, long*, long*)+0x00000308 [/Users/Ed/sync-trunk/objdir/dist/bin/XUL +0x00DF173A]
js_Invoke+0x0000090D [/Users/Ed/sync-trunk/objdir/dist/bin/libmozjs.dylib +0x000A778A]
js_Interpret+0x00016087 [/Users/Ed/sync-trunk/objdir/dist/bin/libmozjs.dylib +0x00093DD5]
js_Execute+0x00000527 [/Users/Ed/sync-trunk/objdir/dist/bin/libmozjs.dylib +0x000A6A76]
JS_EvaluateUCScriptForPrincipals+0x00000119 [/Users/Ed/sync-trunk/objdir/dist/bin/libmozjs.dylib +0x00005E89]
JS_EvaluateScriptForPrincipals+0x00000073 [/Users/Ed/sync-trunk/objdir/dist/bin/libmozjs.dylib +0x00005F32]
ProcessArgs(JSContext*, JSObject*, char**, int)+0x00000643 [/Users/Ed/sync-trunk/objdir/dist/bin/xpcshell +0x00004A65]
main+0x00000AF6 [/Users/Ed/sync-trunk/objdir/dist/bin/xpcshell +0x000055FC]
start+0x00000036 [/Users/Ed/sync-trunk/objdir/dist/bin/xpcshell +0x000018FA]

Comment 4

[Ed Lee :Mardak]

http://hg.mozilla.org/services/fx-sync/rev/0fa59ea429d7
Use do_load_httpd_js for xpcshell tests and have consumers directly call new nsHttpServer().

Comment 5

[Ed Lee :Mardak]

http://hg.mozilla.org/services/fx-sync/rev/57a03f26630f
Just take parts of a static string instead of randomly generating bytes and btoa-ing. 

http://hg.mozilla.org/services/fx-sync/rev/2c54139d77c9
Switch around which lazy services we use to test with but cover even more data types. 

http://hg.mozilla.org/services/fx-sync/rev/0e29bce00e24
Use Utils.delay instead of setTimeout.

Comment 6

[Ed Lee :Mardak]

With the fixes above and changes from the blocking bugs, we're down to 6 test failures:

The 3 original with _storage issues, 2 with login status, and 1 "new" where syncengine_sync now also fail on _storage.

Comment 7

[Ed Lee :Mardak]

Woo! With dolske's suggestion for fixing profile issues (add do_get_profile()), the last 6 test failures are now pass!

http://hg.mozilla.org/services/fx-sync/rev/d1e69da630b2
Get a profile for xpcshell tests so that login manager works (and probably other stuff). Fix up anno test from this change to use a real bookmark id.