573698 - Tooltip trying to look at SVG elements tooltip even if SVG is disabled

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

This produce an error and an empty tooltip is always shown.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 453012 [details] [diff] [review]
Patch v1

>diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js

>   var lookingForSVGTitle = true;
>+#ifndef MOZ_SVG
>+  lookingForSVGTitle = false;
>+#endif // !MOZ_SVG

I would rather:

#ifdef MOZ_SVG
var lookingForSVGTitle = true;
#else
var lookingForSVGTitle = false;
#endif

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch v2

r=gavin

Comment 3

[Mounir Lamouri (:mounir)]

Thank you for the review Gavin :)

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/fbfc0ca2eb6e