Closed
Bug 573733
Opened 15 years ago
Closed 15 years ago
Rename mTabs to tabs in suite tabbrowser
Categories
(SeaMonkey :: Tabbed Browser, defect)
SeaMonkey
Tabbed Browser
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a2
People
(Reporter: kairo, Assigned: kairo)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
23.62 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
Firefox uses gBrowser.tabs, even the mochitest-browser-chrome harness uses that, and we also already use .mTabs outside of tabbrowser, which suggestes it should not have the m prefix that pretends to be internal.
|
Assignee | |
Comment 1•15 years ago
|
||
This should rename all our internal uses, and just as Firefox, adds a <property> for backwards compat.
Attachment #453065 -
Flags: review?(neil)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 453065 [details] [diff] [review]
v1: rename all occurrences, add compatibility shim
> var tabs = [];
>- var mTabs = this._tabbrowser.mTabs;
>+ var mTabs = this._tabbrowser.tabs;
That's confusing variable naming :-(
Attachment #453065 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
(In reply to comment #2)
> (From update of attachment 453065 [details] [diff] [review])
> > var tabs = [];
> >- var mTabs = this._tabbrowser.mTabs;
> >+ var mTabs = this._tabbrowser.tabs;
> That's confusing variable naming :-(
Switched to tabNodes per IRC discussion and pushed as http://hg.mozilla.org/comm-central/rev/a9126328c4a9
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a2
You need to log in
before you can comment on or make changes to this bug.
Description
•