Rename mTabs to tabs in suite tabbrowser

RESOLVED FIXED in seamonkey2.1a2

Status

SeaMonkey
Tabbed Browser
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.1a2
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Firefox uses gBrowser.tabs, even the mochitest-browser-chrome harness uses that, and we also already use .mTabs outside of tabbrowser, which suggestes it should not have the m prefix that pretends to be internal.
(Assignee)

Comment 1

7 years ago
Created attachment 453065 [details] [diff] [review]
v1: rename all occurrences, add compatibility shim

This should rename all our internal uses, and just as Firefox, adds a <property> for backwards compat.
Attachment #453065 - Flags: review?(neil)

Comment 2

7 years ago
Comment on attachment 453065 [details] [diff] [review]
v1: rename all occurrences, add compatibility shim

>     var tabs = [];
>-    var mTabs = this._tabbrowser.mTabs;
>+    var mTabs = this._tabbrowser.tabs;
That's confusing variable naming :-(
Attachment #453065 - Flags: review?(neil) → review+
(Assignee)

Comment 3

7 years ago
(In reply to comment #2)
> (From update of attachment 453065 [details] [diff] [review])
> >     var tabs = [];
> >-    var mTabs = this._tabbrowser.mTabs;
> >+    var mTabs = this._tabbrowser.tabs;
> That's confusing variable naming :-(

Switched to tabNodes per IRC discussion and pushed as http://hg.mozilla.org/comm-central/rev/a9126328c4a9
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a2
(Assignee)

Updated

7 years ago
Blocks: 577756
You need to log in before you can comment on or make changes to this bug.