573786 - Script to detect static initializers

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[(dormant account)]

Need a *hydra script to detect these. I think it's a matter of looking for generated functions that are destined for .ctors section.

Comment 1

[Ehren Metcalfe]

Attachment: script

It's a bit messy to hardcode the name __static_initialization_and_destruction but this is what's done by gcc.

Comment 2

[Ehren Metcalfe]

Attachment: results

note that the calls to __cxa_atexit are to ensure that the destructor for a statically initialized object is called on library unload/exit.

Comment 3

[(dormant account)]

(In reply to comment #2)
> Created an attachment (id=453310) [details]
> results
> 
> note that the calls to __cxa_atexit are to ensure that the destructor for a
> statically initialized object is called on library unload/exit.

Yeah, those are often harmful too. https://bugzilla.mozilla.org/show_bug.cgi?id=569629#c11

Very nice. You even found a few nsCOMPtr globals. Excellent work!

Comment 4

[(dormant account)]

Comment on attachment 453309 [details] [diff] [review]
script

>+          warning(pretty_var(arg) + " defined by call to constructor " + pretty_func(decl) +

>+          warning(pretty_func(decl) + " called during static initialization", location_of(decl));

Nice detailed error messages. This is even better than I expected.

Comment 5

[Ehren Metcalfe]

Attachment: patch v2

changing to use cfg_isn_iterator, carrying over r+.

Comment 6

[Ehren Metcalfe]

Attachment: patch v3

missed a testcase, carrying over r+

Comment 7

[Ehren Metcalfe]

Attachment: patch

added commit message to patch

Comment 8

[[e-mail]]

Comment on attachment 466456 [details] [diff] [review]
patch

http://hg.mozilla.org/mozilla-central/rev/b240b82abfaf