573856 - Optimize sqlite for whole-db-reading usecase

Status: RESOLVED WONTFIX

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[(dormant account)]

A bunch of our databases(eg cookies, downloads) read whole db contents right after opening the db.

Would be nice to be able to tell sqlite to tell the OS to cache these accordingly. Ie use fadvise/readahead on unix and FILE_FLAG_SEQUENTIAL_SCAN on windows.

Comment 1

[Shawn Wilsher :sdwilsh]

(In reply to comment #0)
> A bunch of our databases(eg cookies, downloads) read whole db contents right
> after opening the db.
FWIW, they shouldn't be and we should be fixing that.  Downloads shouldn't be hard to fix if it is doing that, and I think dwitte is already working on a fix for cookies.  Can you file a bug on the components that are doing this please?

Comment 2

[David Teller [:Yoric] - still alive but not very active]

I'm willing to start working on that if someone can point me to one specific case.

Comment 3

[Marco Bonardo [:mak]]

if consumers do that, they should not be using mozStorage. A JSON store is a better target.
We should not optimize for broken consumers.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Note for anyone thinking of fixing consumers: cookies probably wouldn't want to switch to a pure JSON store, but it is a weird use-case that potentially needs some fundamental re-architecting to not store the entirety of a user's cookie store in memory at all times.  Disturbingly, the mork "database" format would be a great fit for cookies' needs.