573910 - switch nsApplicationAccessible to nsAccessible::Append/RemoveChild

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 453314 [details] [diff] [review]
patch

>+++ b/widget/src/gtk2/nsAccessibilityHelper.cpp
>@@ -49,28 +49,28 @@ gint RunDialog(GtkDialog* aDialog)
> {
> #ifdef ACCESSIBILITY
>   if (!nsWindow::sAccessibilityEnabled) {
>     return gtk_dialog_run (aDialog);
>   }
> 
>   nsCOMPtr<nsIAccessibilityService> accService =
>     do_GetService ("@mozilla.org/accessibilityService;1");
>-  nsCOMPtr<nsIAccessible> accessible;
> 
>   // Attach the dialog accessible to app accessible tree
>+  nsAccessible* windowAcc = nsnull;
>   if (accService) {
>     AtkObject* gailWindow = gtk_widget_get_accessible(GTK_WIDGET(aDialog));
>-    accService->AddNativeRootAccessible(gailWindow, getter_AddRefs(accessible));
>+    windowAcc = accService->AddNativeRootAccessible(gailWindow);
>   }
> 
>   gint result = gtk_dialog_run (aDialog);

Are we guaranteed windowAcc will still be valid?

> 
>   // Deattach the dialog accessible
>-  if (accService && accessible) {
>-    accService->RemoveNativeRootAccessible(accessible);
>+  if (accService && windowAcc) {
>+    accService->RemoveNativeRootAccessible(windowAcc);
>   }
> 
>   return result;
> #else
>   return gtk_dialog_run (aDialog);
> #endif
> }

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> >+    windowAcc = accService->AddNativeRootAccessible(gailWindow);
> >   }
> > 
> >   gint result = gtk_dialog_run (aDialog);
> 
> Are we guaranteed windowAcc will still be valid?

Yes, it's kept by application accessible.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 453314 [details] [diff] [review]
patch

OK r=me.

Comment 5

[alexander :surkov (:asurkov)]

Robert, basically I need your review for widget/src/gtk2 part which is trivial.

Comment 6

[alexander :surkov (:asurkov)]

landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/3a9f81291788