573999 - Make mar generation steps dependent on having a previous complete mar to update from

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Chris Cooper [:coop] (he/him)]

Now that we've upgraded to buildbot 0.8.0, we can use Dependent steps to avoid the first-run problem we have right now with partial mar generation for new branches.

We can change the get_previous_mar_filename step to warnOnFailure, and change the remaining mar generation steps to run Dependent on the previousMarFilename property set by that initial step.

Comment 1

[Chris Cooper [:coop] (he/him)]

Testing a patch in staging now that uses a bunch of doStepIf calls.

Comment 2

[Chris Cooper [:coop] (he/him)]

Attachment: Makes mar generation steps conditional on finding the previous complete mar

Uses doStepIf to run the mar generation steps only when the previous complete mar is available on stage. If the previous mar is not found, the build goes orange (warning), but everything else still gets uploaded.

Tested successfully in staging for both en-US and l10n nightlies.

Comment 3

[Chris Cooper [:coop] (he/him)]

Comment on attachment 454059 [details] [diff] [review]
Makes mar generation steps conditional on finding the previous complete mar

http://hg.mozilla.org/build/buildbotcustom/rev/cdaaed009fde

Comment 4

[Chris Cooper [:coop] (he/him)]

pm03 didn't get it's buildbotcustom checkout updated before reconfig yesterday, so I've done that now and reconfig-ed again.

Comment 5

[Chris Cooper [:coop] (he/him)]

The 1.9.2 win pt-PT nightly just went orange (expected) because it couldn't find the previous complete mar, but the new build/mar got uploaded successfully.

Comment 6

[Chris Cooper [:coop] (he/him)]

Still getting exceptions, but I think we just need to set descriptions for the affected steps. Patch coming up.

Comment 7

[Chris Cooper [:coop] (he/him)]

Attachment: Add descriptions to conditional steps

Adding a description overrides the default behavior of looking up all properties when setting the description. Tested on sm03.

Comment 8

[Chris Cooper [:coop] (he/him)]

Comment on attachment 456107 [details] [diff] [review]
Add descriptions to conditional steps

http://hg.mozilla.org/build/buildbotcustom/rev/7a51af31fcb4