574091 - when trying to run 64-bit win7 tests, get the error: c:\Program Files (x86)\GnuWin32\bin\cp.exe: cannot stat `bin/xpcshell': No such file or directory

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

Full log:
(view as text)

bash -c if [ ! -d firefox/plugins ]; then mkdir firefox/plugins; fi && cp bin/xpcshell firefox && cp -R bin/components/* firefox/components/ && cp -R bin/plugins/* firefox/plugins/ && python -u xpcshell/runxpcshelltests.py --symbols-path=symbols --manifest=xpcshell/tests/all-test-dirs.list firefox/xpcshell
 in dir C:\talos-slave\mozilla-central-w764-opt-u-xpcshell\build (timeout 1200 secs)
 watching logfiles {}
 argv: ['bash', '-c', 'if [ ! -d firefox/plugins ]; then mkdir firefox/plugins; fi && cp bin/xpcshell firefox && cp -R bin/components/* firefox/components/ && cp -R bin/plugins/* firefox/plugins/ && python -u xpcshell/runxpcshelltests.py --symbols-path=symbols --manifest=xpcshell/tests/all-test-dirs.list firefox/xpcshell']
 environment:
  ALLUSERSPROFILE=C:\ProgramData
  APACHE="Apache2.2"
  APPDATA=C:\Users\cltbld\AppData\Roaming
  BB_BUILDBOT="c:\mozilla-build\python25\Scripts\buildbot" 
  BB_PYTHON="c:\mozilla-build\python25\Scripts\..\python"
  COMMONPROGRAMFILES=C:\Program Files (x86)\Common Files
  COMMONPROGRAMFILES(X86)=C:\Program Files (x86)\Common Files
  COMMONPROGRAMW6432=C:\Program Files\Common Files
  COMPUTERNAME=T-R3-W764-004
  COMSPEC=C:\Windows\system32\cmd.exe
  CONTROLFILE="c:\users\cltbld\buildbot-tac.control"
  CVS_RSH=ssh
  FP_NO_HOST_CHECK=NO
  HOMEDRIVE=C:
  HOMEPATH=\Users\cltbld
  HOSTNAME=t-r3-w764-004
  LOCALAPPDATA=C:\Users\cltbld\AppData\Local
  LOGONSERVER=\\T-R3-W764-004
  MINIDUMP_STACKWALK=c:/talos-slave/mozilla-central-w764-opt-u-xpcshell/tools/breakpad/win64/minidump_stackwalk.exe
  MOZ_CRASHREPORTER_NO_REPORT=1
  MOZ_NO_REMOTE=1
  NO_EM_RESTART=1
  NO_FAIL_ON_TEST_ERRORS=1
  NUMBER_OF_PROCESSORS=2
  OS=Windows_NT
  PASSWORD="secret"
  PATH=C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;c:\python26;c:\python26\scripts;C:\Program Files (x86)\GnuWin32\bin;c:\mozilla-build\msys\bin;c:\mozilla-build\hg;c:\mozilla-build\vim\vim72;c:\mozilla-build\python25;c:\mozilla-build\7zip;c:\mozilla-build\info-zip;c:\mozilla-build\wget;c:\mozilla-build\python25\scripts
  PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC
  PROCESSOR_ARCHITECTURE=x86
  PROCESSOR_ARCHITEW6432=AMD64
  PROCESSOR_IDENTIFIER=Intel64 Family 6 Model 23 Stepping 10, GenuineIntel
  PROCESSOR_LEVEL=6
  PROCESSOR_REVISION=170a
  PROGRAMDATA=C:\ProgramData
  PROGRAMFILES=C:\Program Files (x86)
  PROGRAMFILES(X86)=C:\Program Files (x86)
  PROGRAMW6432=C:\Program Files
  PROGS=C:\Program Files (x86)
  PROMPT=$P$G
  PSMODULEPATH=C:\Windows\system32\WindowsPowerShell\v1.0\Modules\
  PUBLIC=C:\Users\Public
  PWD=C:\talos-slave\mozilla-central-w764-opt-u-xpcshell\build
  SYSTEMDRIVE=C:
  SYSTEMROOT=C:\Windows
  TACFILE="c:\talos-slave\buildbot.tac"
  TACSCRIPT="c:\tools\buildbot-helpers\buildbot-tac.py"
  TEMP=C:\Users\cltbld\AppData\Local\Temp
  TMP=C:\Users\cltbld\AppData\Local\Temp
  TYPE=w764
  USERDOMAIN=T-R3-W764-004
  USERNAME=cltbld
  USERPROFILE=C:\Users\cltbld
  WINDIR=C:\Windows
  XPCOM_DEBUG_BREAK=warn
 closing stdin
 using PTY: False
c:\Program Files (x86)\GnuWin32\bin\cp.exe: cannot stat `bin/xpcshell': No such file or directory
program finished with exit code 1
elapsedTime=0.314000

Comment 1

[[e-mail] (:bhearsum)]

Attachment: use explicit name for xpcshell binary

Turns out that MSYS will automatically look for .exe (or .dll) files when you don't give an extension. This hasn't been working on 64-bit Windows 7, presumably because we're using the gnuwin32 'cp'. (Strangely, it works on 32-bit Windows 7 and we use the gnuwin32 'cp' there, too). In any case, being explicit is better IMHO, and this patch fixes it to be that way.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 453834 [details] [diff] [review]
use explicit name for xpcshell binary

Landed on default and buildbot-0.8.0:
changeset:   817:cbcdd8232cfa
branch:      buildbot-0.8.0

changeset:   816:1549a1120883


Armen is updating tm*, I'm doing pm01/03

Comment 3

[[e-mail] (:bhearsum)]

Should be all done here now.

Comment 4

[[e-mail] (:bhearsum)]

Caused bustage tracked in bug 578388.