Closed
Bug 574123
Opened 15 years ago
Closed 15 years ago
Add support for zoom-to-rect for zooming to an element
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
Attachments
(2 files)
9.22 KB,
patch
|
mbrubeck
:
review+
mbrubeck
:
feedback+
|
Details | Diff | Splinter Review |
4.15 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
e10s broke the ability to double tap to zoom into an element. Easy enough to split it up and add it back.
Assignee | ||
Comment 1•15 years ago
|
||
This patch uses messages to send the element bounding rect back to the chrome side, where we use it with the existing zoom code.
* Changed _getZoomRectForElement -> _getZoomRectForRect
* Combined some of the zoom helper code into a single function
This works OK on local pages, but rendering problems make it hard to see zooming work on remote pages. That is a separate bug.
Try it out on about:firstrun to zoom into the middle images, for example.
Assignee: nobody → mark.finkle
Attachment #453828 -
Flags: review?(21)
Assignee | ||
Updated•15 years ago
|
Attachment #453828 -
Flags: feedback?(mbrubeck)
Updated•15 years ago
|
Attachment #453828 -
Flags: feedback?(mbrubeck) → feedback+
Assignee | ||
Updated•15 years ago
|
Attachment #453828 -
Flags: review?(21) → review?(mbrubeck)
Updated•15 years ago
|
Attachment #453828 -
Flags: review?(mbrubeck) → review+
Assignee | ||
Comment 2•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 3•15 years ago
|
||
Oops, I missed this during review, but FormHelper._zoom is broken now because it used _getZoomLevelForRect. Sorry!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 4•15 years ago
|
||
This patch adds _getZoomLevelForRect back (for FormHelper._zoom) and splits zoomToPoint and zoomFromPoint back into separate functions. I saw Brad wanted to know what happened to the function, so I added it back.
Attachment #453960 -
Flags: review?(mbrubeck)
Comment 5•15 years ago
|
||
Comment on attachment 453960 [details] [diff] [review]
bustage fix
> _getZoomRectForRect: function _getZoomRectForRect(rect, y) {
> const margin = 15;
This is unused now, can be deleted. r+ with that minor fix.
Attachment #453960 -
Flags: review?(mbrubeck) → review+
Assignee | ||
Comment 6•15 years ago
|
||
removed unused const
pushed:
http://hg.mozilla.org/mobile-browser/rev/4e0939e231cd
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Comment 7•14 years ago
|
||
about:firstrun page is not available any more on the latest Nightly build. How could I verify this issue?
Comment 8•14 years ago
|
||
This is fixed if you can double-tap to zoom in to an element on a web page. The browser should zoom so that the tapped element fits the screen width.
Comment 9•14 years ago
|
||
(In reply to Matt Brubeck (:mbrubeck) from comment #8)
> This is fixed if you can double-tap to zoom in to an element on a web page.
> The browser should zoom so that the tapped element fits the screen width.
Then it seems that this issue is verified fixed on the latest Nightly build.
--
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110921
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•