Closed
Bug 574228
Opened 14 years ago
Closed 14 years ago
PopupNotifications should ignore missing secondaryActions argument
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
VERIFIED
FIXED
mozilla2.0b1
People
(Reporter: mossop, Assigned: Gavin)
References
Details
(Whiteboard: [doorhanger])
Attachments
(1 file)
|
3.12 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
Not passing this argument or passing null causes the show method to throw an exception.
|
Assignee | |
Comment 1•14 years ago
|
||
The Notification() constructor already has a fallback to [], this was just caused by overly strict argument validation.
|
Reporter | |
Updated•14 years ago
|
Attachment #453614 -
Flags: review?(dtownsend) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 2•14 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b7b9bebb1e43
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-litmus+
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a6
|
||
Updated•14 years ago
|
Blocks: sm-doorhanger
|
|
Assignee | |
Updated•14 years ago
|
Flags: in-litmus+ → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•