Closed Bug 574438 Opened 10 years ago Closed 10 years ago

Need to pass a PRBool to ConfirmEx's checkValue parameter

Categories

(MailNews Core :: Backend, defect, major)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file, 1 obsolete file)

Before bug 563274 the prompting code was written in C++ and specifically did not attempt to use the checkValue parameter if no checkMsg string was provided. Unfortuantely we no longer have that luxury. In fact, we have to pass an initialised PRBool, so there are six call sites that need to be fixed.

I originally noticed this trying to delete a local folder; I haven't actually attempted to verify the fix for any of the other call sites.
Attached patch Proposed patch (obsolete) — Splinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #453833 - Flags: superreview?(bienvenu)
Attachment #453833 - Flags: review?
Attachment #453833 - Flags: review? → review?(bienvenu)
Most callers use nsIAuthPrompt which does not have this issue.
(This also goes for the some of the other Prompt function calls.)
Attachment #453833 - Attachment is obsolete: true
Attachment #453836 - Flags: superreview?(bienvenu)
Attachment #453836 - Flags: review?(bienvenu)
Attachment #453833 - Flags: superreview?(bienvenu)
Attachment #453833 - Flags: review?(bienvenu)
Attachment #453836 - Flags: superreview?(bienvenu)
Attachment #453836 - Flags: superreview+
Attachment #453836 - Flags: review?(bienvenu)
Attachment #453836 - Flags: review+
Pushed changeset f27e030e9a14 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Duplicate of this bug: 573591
Pushed as http://hg.mozilla.org/comm-central/rev/51b6b3c86072 to the 2.1a2 relbranch, so this is fixed there (in build2) as well.
You need to log in before you can comment on or make changes to this bug.