574442 - can't select module after adding it to library

Status: RESOLVED WORKSFORME

(Mozilla Labs Graveyard :: FlightDeck, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When I enter the name for a module into the "Add module" field and press the Add button while editing a library, I see a notification "Success - module [name] added", and the name of the module appears in the list of modules in the library.

But I am unable to select the module.  Clicking on the module name doesn't do anything in the UI, it just generates the following message in the error console:

Error: switch_mode_on is not defined
Source file: https://lm-app-flightdeck-stage01.mozillalabs.com/media/jetpack/js/FlightDeck.Editor.js
Line: 20

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Reloading the editor resolved this problem, so perhaps it only happens when you first create a library?

Comment 2

[Piotr Zalewa [:zalun]]

Couldn't reproduce, but the function was in wrong scope - I moved it to the right place. Please test.
http://github.com/zalun/FlightDeck/commit/f2840f323069ada00d4674cfbc97e8324c8147a2

Comment 3

[Dietrich Ayala (:dietrich)]

WFM in the currently-deployed release.