574447 - pressing Save in library displays "Error 403: Forbidden - There is already a revision with that name"

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: FlightDeck, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When I press the Save button while editing a library, FlightDeck displays the notification "Error 403: Forbidden - There is already a revision with that name".  It should save my changes to the library.

I saw this behavior after creating a library, renaming it, and adding two modules to it.  Once I reloaded the editor, however, the problem went away.  So perhaps this only happens when you first create a library?

Comment 1

[Piotr Zalewa [:zalun]]

It should happen only when one is trying to create a new revision with the version name which already existed in that Package and it wasn't the last saved version.
In example

rev. ver.
0    initial
1    one
2    initial <- raises an error

I will write a work around - I will set the revision top an empty string in such case.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

My steps to reproduce the problem are:

1. On the home page, press the Create Library button.  FD takes you to the editor.
2. Enter "foo" into the "Add module" field and press the Add button.  FD adds the "foo" module.
3. Enter "bar" into the "Add module" field and press the Add button.  FD adds the "bar" module.
4. Click the name of the library.  FD opens the Edit Info dialog.
5. Change the name of the library and press the OK button.  FD closes the dialog.
6. Press the Save button.

Expected Results: FD notifies you that it has saved your changes (or that there are no changes to save).

Actual Results: FD notifies you "Error 403 - FORBIDDEN - There is already a revision with that name".

Comment 3

[Piotr Zalewa [:zalun]]

I think it was broken after first module added - The Modules tab didn;t had the number (0) and system was failing to change it. 
No error on localhost after this fix:
http://github.com/zalun/FlightDeck/commit/660f317bb4857ec22b146456684d9b19944683e9

Comment 4

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #3)
> I think it was broken after first module added

I just tested it again, and you're right, the problem occurs after only adding a single module.