Closed
Bug 574530
Opened 15 years ago
Closed 15 years ago
Don't load PopupNotifications in onLocationChange if it's not initialized yet
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 4.0b1
People
(Reporter: kairo, Assigned: Gavin)
References
Details
(Whiteboard: [doorhanger])
Attachments
(1 file, 1 obsolete file)
|
1.38 KB,
patch
|
Details | Diff | Splinter Review |
See bug 570004 comment #10 - we currently load PopupNotifications in onLocationChange even if it hadn't been in use yet, which we probably should avoid (I guess we probably load it at startup now as soon as the location changes the first time, but we really should only load it once we actually need a popup notification).
|
Assignee | |
Comment 1•15 years ago
|
||
Adding another global is kind of annoying, but I don't think there is a better option...
|
||
Comment 2•15 years ago
|
||
Comment on attachment 454120 [details] [diff] [review]
patch
if (!__lookupGetter__("PopupNotifications")) would probably work...
Attachment #454120 -
Flags: review?(dao) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Indeed, it does.
Attachment #454120 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a6
You need to log in
before you can comment on or make changes to this bug.
Description
•