574536 - Should not be trying to package debug builds on 1.9.1

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Phil Ringnalda (:philor)]

The debug Linux builds on Firefox3.5 have been burning since last Sunday from an error in the "make package" step, which is sort of weird since really every platform's debug builds should be burning, and should have been burning since whenever someone turned on packaging of debug builds on 1.9.1.

You can only package debug builds on mozilla-central, since that's where it became possible to build libxul+debug, which is what you should have to do to get past the packaging makefile's check, and is what you have to do to make a package that will run, since the package-manifest file doesn't include all the necessary files for a --disable-libxul build to work.

Not giving this the proper severity, blocker, since apparently nobody actually cared that the Linux debug builds had been red for four days, so it can't be described as "stopping development."

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Looks like this is a regression from switching to buildbot 0.8.0, as I can't find any make_upload steps for linux 1.9.1 debug in the statusdb prior to 2010-06-18 20:47:05 UTC. By inspection we're calling make package/upload for 1.9.1 mac, and 1.9.2 linux & mac, but not win32 for those branches.

May explain my confusion at bug 400083 comment #41.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

There's a lot of red debug builds adding noise to the 1.9.1 tree, gonna fix this.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Disable packaging and uploads

Making this config change removes the following steps from the 1.9.1 leak test factories (as reported by braindump/buildbot-related/builder_list.py)
 make_package-tests
 make_package
 find_filepath
 set_package_filename
 set_package_size
 set_package_hash
 unset_filepath
 get_buildid
 get_app_version
 make_upload
 2x sendchanges
and we doesn't touch any other branches. We don't need any of those steps for 1.9.1 since we don't use the builds for tests elsewhere.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 463975 [details] [diff] [review]
Disable packaging and uploads

http://hg.mozilla.org/build/buildbot-configs/rev/39f848ff18cc

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

pm01 and 03 reconfig'd and a linux build went green. Others pending. Will reopen if they don't work.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Followup to fix linux64 too:
 http://hg.mozilla.org/build/buildbot-configs/rev/c8fd73f69796