574556 - (bz-search-args) Refactor Search.pm so that we're not doing $$some_var everywhere

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[Max Kanat-Alexander]

Instead of doing $$term, $$f, etc., I think that we should just be setting values in a passed-in hashref. (That is, pass in $func_args instead of %func_args, and just set values in the hash.)

Comment 1

[Max Kanat-Alexander]

Attachment: Work In Progress

Comment 2

[Max Kanat-Alexander]

Attachment: WIP 2

Comment 3

[Max Kanat-Alexander]

Attachment: v1

All right, this is a major refactoring that I have tested extensively. I've sent an email to LpSolit asking him if he's OK with me simply owning Search.pm, so that I can continue to refactor it without review. However, in any case, here is the patch for review, until I get that approval.

Comment 4

[Max Kanat-Alexander]

Comment on attachment 454181 [details] [diff] [review]
v1

Okay, I have approval to have a review-free period on Search.pm for 4.2.

Comment 5

[Max Kanat-Alexander]

However, I'm waiting on the xt/search.t test to be done, before I check anything in.

Comment 6

[Max Kanat-Alexander]

Attachment: v2

Okay! Well, xt/search.t found various bugs in the refactored code (mostly related to strange fields like percentage_complete and owner_idle_time). The test also demonstrates that hundreds of combinations are now working properly, thanks to a little bit of cleanup I did during the patch. This required updating xt/search.t's KNOWN_BROKEN bits pretty extensively, so that's also in this patch.

Comment 7

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Bug.pm
modified Bugzilla/Group.pm
modified Bugzilla/Search.pm
modified template/en/default/global/code-error.html.tmpl
modified template/en/default/global/user-error.html.tmpl
modified xt/lib/Bugzilla/Test/Search/Constants.pm
Committed revision 7299.