Bug 574556 (bz-search-args)

Refactor Search.pm so that we're not doing $$some_var everywhere

RESOLVED FIXED in Bugzilla 4.2

Status

()

Bugzilla
Query/Bug List
--
enhancement
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

(Blocks: 1 bug)

Bugzilla 4.2
Dependency tree / graph
Bug Flags:
approval +

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

8 years ago
Instead of doing $$term, $$f, etc., I think that we should just be setting values in a passed-in hashref. (That is, pass in $func_args instead of %func_args, and just set values in the hash.)
(Assignee)

Updated

8 years ago
Blocks: 574567
(Assignee)

Updated

8 years ago
Alias: bz-search-args
(Assignee)

Updated

8 years ago
Blocks: 574572
(Assignee)

Updated

8 years ago
Depends on: 574577
(Assignee)

Updated

8 years ago
Blocks: 574577
No longer depends on: 574577
(Assignee)

Updated

8 years ago
Blocks: 574587
(Assignee)

Comment 1

8 years ago
Created attachment 453978 [details] [diff] [review]
Work In Progress
Assignee: query-and-buglist → mkanat
Status: NEW → ASSIGNED
(Assignee)

Updated

8 years ago
Blocks: 574625
(Assignee)

Comment 2

8 years ago
Created attachment 454008 [details] [diff] [review]
WIP 2
Attachment #453978 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Blocks: 490322
(Assignee)

Comment 3

8 years ago
Created attachment 454181 [details] [diff] [review]
v1

All right, this is a major refactoring that I have tested extensively. I've sent an email to LpSolit asking him if he's OK with me simply owning Search.pm, so that I can continue to refactor it without review. However, in any case, here is the patch for review, until I get that approval.
Attachment #454008 - Attachment is obsolete: true
Attachment #454181 - Flags: review?(jjclark1982)
(Assignee)

Updated

8 years ago
Blocks: 574879
(Assignee)

Updated

8 years ago
Blocks: 575021
(Assignee)

Updated

8 years ago
Blocks: 575022
(Assignee)

Comment 4

8 years ago
Comment on attachment 454181 [details] [diff] [review]
v1

Okay, I have approval to have a review-free period on Search.pm for 4.2.
Attachment #454181 - Flags: review?(jjclark1982) → review+
(Assignee)

Comment 5

8 years ago
However, I'm waiting on the xt/search.t test to be done, before I check anything in.
No longer blocks: 574879
Depends on: 574879
Flags: approval?
Target Milestone: --- → Bugzilla 4.2
(Assignee)

Comment 6

8 years ago
Created attachment 456391 [details] [diff] [review]
v2

Okay! Well, xt/search.t found various bugs in the refactored code (mostly related to strange fields like percentage_complete and owner_idle_time). The test also demonstrates that hundreds of combinations are now working properly, thanks to a little bit of cleanup I did during the patch. This required updating xt/search.t's KNOWN_BROKEN bits pretty extensively, so that's also in this patch.
Attachment #454181 - Attachment is obsolete: true
Attachment #456391 - Flags: review+
(Assignee)

Updated

8 years ago
Flags: approval? → approval+
(Assignee)

Comment 7

8 years ago
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Bug.pm
modified Bugzilla/Group.pm
modified Bugzilla/Search.pm
modified template/en/default/global/code-error.html.tmpl
modified template/en/default/global/user-error.html.tmpl
modified xt/lib/Bugzilla/Test/Search/Constants.pm
Committed revision 7299.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Blocks: 579797

Updated

7 years ago
Blocks: 674497

Updated

6 years ago
Blocks: 788098
You need to log in before you can comment on or make changes to this bug.