574724 - New Title bar breaks Aero Snap / Aero Shake

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect, P1)

Description

[Gary [:streetwolf52]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100625 Minefield/3.7a6pre Firefox/3.6.4
Build Identifier: 20100625091320

With the advent of https://bugzilla.mozilla.org/show_bug.cgi?id=513162 (probably)
W7 Aero Snap does not work. Also when Fx is maximized the Taskbar can't be brought up if it is Auto Hidden.

Reproducible: Always

Comment 1

[Rob Arnold [:robarnold]]

Snap WFM in today's nightly. Jim just checked in a fix in bug 574635 - you could check for an hourly build that has it to see if that fixes it for you?

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

Setting to NEW, as I'm pretty sure this worked before the landing of Drawing in Titlebar, but will see what the fix for 574635 brings

Comment 3

[Rob D]

Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100625 Minefield/3.7a6pre

Snap & Doubleclick on titlebar to maximize are both broken here.

Comment 4

[Gary [:streetwolf52]]

In order to have the taskbar popup when a window is maximized the window has to leave about a 1px gap on the bottom.  

Also when resizing the Fx window the taskbar will pop under the Fx window if it's down by the taskbar.  This should not happen.

Comment 5

[[not reading bugmail]]

A couple points to note when thinking about if this is fixed or not:

1) Title bar aero snap does work with hourly with bug 574645 using the menu bar is visible.

2) However it doesn't work when using titlebar menu to the edge of the window from bug 574435.

3) Mstange also said Aero snap is also going to be addressed in bug 555081 for toolbars.

So not sure where this bug falls..

Comment 6

[[not reading bugmail]]

(In reply to comment #5)
> A couple points to note when thinking about if this is fixed or not:
> 
> 1) Title bar aero snap does work with hourly with bug 574645 using the menu bar
> is visible.

Ah sorry for the spam mail: s/b bug 574635

Comment 7

[Gary [:streetwolf52]]

When the menu is displayed the caption br appears to be the real one which is why aero snap works.

Also it appears having the menu bar visible also fixes the taskbar problem.

Comment 8

[Gary [:streetwolf52]]

Might as well add this here too.  There is what seems like 1 pixel on the top border when not maximized in order to resize the window.  Unlike the sides and bottom border which I presume are the normal Window borders and allow at more room.

Comment 9

[Rob Arnold [:robarnold]]

(In reply to comment #8)
> Might as well add this here too.  There is what seems like 1 pixel on the top
> border when not maximized in order to resize the window.  Unlike the sides and
> bottom border which I presume are the normal Window borders and allow at more
> room.

Bug 574802

Comment 11

[Jim Mathies [:jimm]]

Unduping, as I think the fix for the maximized window issue bug will address this, and it may not require additional hit test code. I'll come back to this after that fix lands.

Comment 14

[Zackery]

Aero Snap still refuses to work with menu bar disabled. With menu bar enabled if you click and grab within any area to the right of the last menu option and if that area is within the height of the menu bar and you then try to perform aero snap on either top maximize or side half screen it doesn't work. Also, if the window is maximized and you grab within that same area and try to drag the window across the screen the mouse cursor moves a bit to the right. The closer you grab it to the far edge the mouse cursor moves outside the firefox window altogether yet you can still move the window around.

Comment 15

[Jim Mathies [:jimm]]

(In reply to comment #14)
> Aero Snap still refuses to work with menu bar disabled. With menu bar enabled
> if you click and grab within any area to the right of the last menu option and
> if that area is within the height of the menu bar and you then try to perform
> aero snap on either top maximize or side half screen it doesn't work. Also, if
> the window is maximized and you grab within that same area and try to drag the
> window across the screen the mouse cursor moves a bit to the right. The closer
> you grab it to the far edge the mouse cursor moves outside the firefox window
> altogether yet you can still move the window around.

Which version are you using? The patch for this just landed a few hours ago on mozilla central. It should be in tomorrow's nightly.

Comment 16

[Zackery]

(In reply to comment #15)
> (In reply to comment #14)
> > Aero Snap still refuses to work with menu bar disabled. With menu bar enabled
> > if you click and grab within any area to the right of the last menu option and
> > if that area is within the height of the menu bar and you then try to perform
> > aero snap on either top maximize or side half screen it doesn't work. Also, if
> > the window is maximized and you grab within that same area and try to drag the
> > window across the screen the mouse cursor moves a bit to the right. The closer
> > you grab it to the far edge the mouse cursor moves outside the firefox window
> > altogether yet you can still move the window around.
> 
> Which version are you using? The patch for this just landed a few hours ago on
> mozilla central. It should be in tomorrow's nightly.


I'm currently using Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100627 Minefield/3.7a6pre

Comment 17

[Jim Mathies [:jimm]]

(In reply to comment #16)
> (In reply to comment #15)
> > (In reply to comment #14)
> > > Aero Snap still refuses to work with menu bar disabled. With menu bar enabled
> > > if you click and grab within any area to the right of the last menu option and
> > > if that area is within the height of the menu bar and you then try to perform
> > > aero snap on either top maximize or side half screen it doesn't work. Also, if
> > > the window is maximized and you grab within that same area and try to drag the
> > > window across the screen the mouse cursor moves a bit to the right. The closer
> > > you grab it to the far edge the mouse cursor moves outside the firefox window
> > > altogether yet you can still move the window around.
> > 
> > Which version are you using? The patch for this just landed a few hours ago on
> > mozilla central. It should be in tomorrow's nightly.
> 
> 
> I'm currently using Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US;
> rv:1.9.3a6pre) Gecko/20100627 Minefield/3.7a6pre

Give it a day and do an update. ;)

Comment 18

[Jim Mathies [:jimm]]

Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100628 Firefox/3.6.4 ( .NET CLR 3.5.30729; .NET4.0C)

confirmed fixed.

Comment 19

[Jim Jeffery not reading bug-mail 1/2/11]

Just tested using today's nightly.  Aero-snap seems to be working, but Aero-shake still does not minimize the window.  

Is there some 'magic' border or something that Win7 is looking for ?  Even some of my old programs I've had way before Win7, will minimize when 'shaken'.

Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100628 Minefield/3.7a6pre ID:20100628035917

Comment 20

[Gary [:streetwolf52]]

Now that 555081 landed and aero snap/shake works will you be fixing the taskbar problem as stated in Comment 4 or should I open another bug report?

Comment 21

[Gary [:streetwolf52]]

Actually I can get the taskbar to popup under certain conditions.  If I un-maximize the window to something smaller and move it to the bottom edge of the screen(just to see what's happening) you will see how the taskbar pops under the window.  If I then click outside the window like on the desktop, the taskbar will pop over the window.  If I then max the window the taskbar might now popup.  I say might because sometimes it take two tries to get this accomplished.

Comment 22

[Gary [:streetwolf52]]

Correction - Usually many tries.  I sometimes see the thin taskbar line at the bottom but it disappears in a second or two after maximizing the window. Once it awhile it 'sticks'.

Comment 23

[Jim Mathies [:jimm]]

(In reply to comment #4)
> In order to have the taskbar popup when a window is maximized the window has to
> leave about a 1px gap on the bottom.  
> 
> Also when resizing the Fx window the taskbar will pop under the Fx window if
> it's down by the taskbar.  This should not happen.

Definitely file another bug. Maybe provide a wee bit more detail? (I'm not sure I understand what you mean by "pop-up".) Please cc :jimm.

Comment 24

[Jim Mathies [:jimm]]

(In reply to comment #19)
> Just tested using today's nightly.  Aero-snap seems to be working, but
> Aero-shake still does not minimize the window.  
> 
> Is there some 'magic' border or something that Win7 is looking for ?  Even some
> of my old programs I've had way before Win7, will minimize when 'shaken'.
> 
> Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre)
> Gecko/20100628 Minefield/3.7a6pre ID:20100628035917

Shake is definitely WFM here, using last night's build. I tested on multiple points within the glass.

Comment 25

[Jim Jeffery not reading bug-mail 1/2/11]

I just tested with a new Profile and did not install any addons, and it didn't work on a new profile. 

something else your build that maybe has not been pushed to m-c ?

Comment 26

[Jim Jeffery not reading bug-mail 1/2/11]

Oh crap !  My bad...  I was trying to shake Minefield to minimize, Shake closes/minimizes 'other apps'.. DUH!

Sorry for the spam.

Re-closing