574817 - xpcom/reflect/xptinfo/src/xptiInterfaceInfo.cpp:118: warning: unused variable 'mgr'

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel Holbert [:dholbert]]

Just noticed a message go by in compiler-spew for this variable being unused:
http://hg.mozilla.org/mozilla-central/annotate/b51803f3fdef/xpcom/reflect/xptinfo/src/xptiInterfaceInfo.cpp#l118
{
> 108 PRBool 
> 109 xptiInterfaceEntry::ResolveLocked()
> 110 {
[...]
> 118     xptiInterfaceInfoManager* mgr = > xptiInterfaceInfoManager::GetSingleton();
}

This is basically identical to the line that I tweaked in bug 573530, which was a place where we intentionally triggered a lazy initializer during startup.

Is there any reason we need to trigger the lazy initializer here, too?  (won't it already have been triggered?)

Comment 1

[Daniel Holbert [:dholbert]]

> 118     xptiInterfaceInfoManager* mgr = > xptiInterfaceInfoManager::GetSingleton();
(Sorry, that ">" shouldn't be there in the middle of the line -- accidental addition)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix: remove variable

Unless there's a reason we'd want to trigger lazy-initialization here (and it wouldn't already have been triggered by the line in bug 573530), it looks like this line should just be removed.

Comment 3

[Daniel Holbert [:dholbert]]

Looks like bsmedberg fixed this in bug 568691.