Closed
Bug 574974
Opened 14 years ago
Closed 14 years ago
Split inner/outer scriptable helpers
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
25.56 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
bug 574517 led the way here. This bug is a lot more aggressive. I have a partial patch that starts up, but does something wrong with principals, so page JS isn't allowed to access itself.
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Comment 2•14 years ago
|
||
Much smaller patch... There's no change in behavior here, but it shows how we can share common code for now and move inner/outer specific behavior to sub-classes.
Attachment #454295 -
Attachment is obsolete: true
Attachment #462529 -
Flags: review?(jst)
|
||
Updated•14 years ago
|
Attachment #462529 -
Flags: review?(jst) → review+
|
||
Updated•14 years ago
|
Blocks: compartments
|
|
||
Comment 3•14 years ago
|
||
I landed this earlier today. http://hg.mozilla.org/tracemonkey/rev/35fd077aad03
|
||
Updated•14 years ago
|
|
|
Assignee | |
Comment 4•14 years ago
|
||
The bug # in the checkin comment points to bug 574975, fwiw.
Whiteboard: fixed-in-tracemonkey
|
|
Assignee | |
Updated•14 years ago
|
Summary: Split inner/outer scriptable helpers, make the outer window not global → Split inner/outer scriptable helpers
|
||
Comment 5•14 years ago
|
||
That's info that should go in that bug, no?
|
|
||
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/35fd077aad03
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•