575188 - XPCOM stack walker on Windows should print library+offset

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jesse Ruderman]

When a Windows build has insufficient symbols, the XPCOM stack walker should print library+offset rather than badsym+offset.  Preferably in the same format that Mac and Linux use.

I'd accept both (e.g. library+offset + badsym+offset) if it's hard to detect whether the symbols available to the stack walker are "insufficient".

This would allow Windows Tinderbox tests to use fix_stack_using_bpsyms.py and get decent stack traces.

Comment 1

[Jesse Ruderman]

Attachment: example of bad output on tinderbox

Comment 2

[Jesse Ruderman]

Attachment: example of good output from a local debug build

The Windows stack walker actually works really well on non-stripped builds.  It's only stripped builds that would benefit from this change.

Comment 3

[Jesse Ruderman]

Fixing this might be as simple as grabbing aDetails->loffset in NS_FormatCodeAddressDetails.  But I get disoriented by all the ifdefs in nsStackWalk.cpp.

Comment 4

[Shawn Wilsher :sdwilsh]

Fixing this would help debug assertions that are only seen on tinderbox.  I've got a few right now that I can't reproduce locally, and are windows only :(

Comment 5

[Shawn Wilsher :sdwilsh]

In fact, I'd say that it's preventing me from fixing bug 599969 (blocker).

Comment 6

[Dietrich Ayala (:dietrich)]

Blocking, since it blocks a blocker.

Comment 7

[Shawn Wilsher :sdwilsh]

Don't need this for bug 612617 anymore.

Comment 8

[Jesse Ruderman]

Fixed by Ted as part of his patch in bug 751673.

Comment 9

[(not currently active) Ted Mielczarek]

I kinda forgot there was a bug on this.