Closed Bug 57522 Opened 26 years ago Closed 25 years ago

ALT + Enter does not work for bookmark properties

Categories

(Core :: DOM: UI Events & Focus Handling, enhancement, P3)

x86
Windows NT
enhancement

Tracking

()

VERIFIED FIXED

People

(Reporter: dev+mozilla, Assigned: bugzilla)

Details

Attachments

(1 file)

From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; m18) Gecko/20001011 BuildID: 2000101104 ALT + SPACE should work as shortcut for bookmark properties. Reproducible: Always Steps to Reproduce: 1. In Bookmark Manager, select a bookmark. 2. Press ALT+SPACE. Actual Results: Nothing happens. Expected Results: The "bookmark properties" should open.
do you mean alt + enter? alt + space opens the min/max/close menu on windows 98 for most apps.
Oops, of course I mean ALT + <em>Enter</em>. Updating Summary.
Summary: ALT + SPACE does not work for bookmark properties → ALT + Enter does not work for bookmark properties
Confirming.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Netscape Nav triage team: this is not a Netscape beta stopper. Changing component to keyboard navigation
Component: Bookmarks → Keyboard Navigation
Keywords: nsbeta1-
Where did alt+enter come from? Current setting looks like it should be ctrl-I, which does not work for me on linux.
alt+enter [accel+enter for xp nuts] is a standard feature of windows (to get properties for an object) it also works in nc4. actually, alt+doubleclick should also work (according to the os) but i doubt we'll implement that.
Keywords: 4xp
alt(option)+dbl-click has worked for sometime now on the mac btw.
ooh cool.
Attached patch patch — — Splinter Review
cc'ing alec for sr...
Assignee: ben → blakeross
I prefer goDoCommand("cmd_" + aEvent.altKey ? "properties" : "open");
I like Blake's code better (easier to read).
Yes, I considered that, and then decided not to for the reason Jesse pointed out. But I guess I could change it if some of the more obsessive compulsive people want me to (not mentioning names)....
i wonder if ben's is more expensive. brendan, any comments?
Ben's version needs to parenthesize the ?: expression so that + doesn't bind to aEvent.altKey, concatenating to yield an always-converts-to-true condition for the ?: that selects as its result only "properties". The fastest, also most concise yet still quite clear, version is: goDoCommand(aEvent.altKey ? "cmd_properties" : "cmd_open"); No string concatenation, no repeated function call (which wastes bytecode space). /be
Yes, I'd buy that (given that I never actually applied the patch or tested my suggestion ;)
This got fixed by some checkin before 2001031204.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31. if you think this particular bug is not fixed, please make sure of the following before reopening: a. retest with a *recent* trunk build. b. query bugzilla to see if there's an existing, open bug (new, reopened, assigned) that covers your issue. c. if this does need to be reopened, make sure there are specific steps to reproduce (unless already provided and up-to-date). thanks! [set your search string in mail to "AmbassadorKoshNaranek" to filter out these messages.]
Status: RESOLVED → VERIFIED
Component: Keyboard: Navigation → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: