575243 - Top left re-sizer is masked by the Minefield Button

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

Trying to access the top left re-sizer in Win7 using today's nightly build is impossible.  It seems that the area in the top-left of the browser is being captured by the Minefield/Firefox button. 

Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100628 Minefield/3.7a6pre ID:20100628035917

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Not sure what we want to do here - probably just adjust the hit zone a little.

Faaborg/Dao?

Comment 2

[:Felipe Gomes (needinfo for replies!)]

A little hitzone protection was added around the Firefox button so that resizers wouldn't take over the clickable area of the button. The protection was too agressive on that corner, but reclaiming some pixels to the top-left resizer should be easy.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

yeah as long as the pixels match the hit zones we should be fine.

Comment 4

[imradyurrad]

If possible can we get this fixed today? It feels rather awkward having to draw the bottom right to resize a window.

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Attachment: Fix

Upon further investigation, the root of the problem was that the top-left resizer is in an area where there's no content to receive the hittest messages, so the hittest falls back to the default behavior of considering the point as inside the client area.

Jimm, I believe that this is the solution we talked about. With the patch, we don't send the hittest messages to safeguard the border areas where we're sure that there's no content being rendered.

Comment 8

[Jim Mathies [:jimm]]

Comment on attachment 458036 [details] [diff] [review]
Fix

works great!

Comment 9

[imradyurrad]

Not in trunk yet?

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/43557ed3076e