Closed
Bug 575243
Opened 15 years ago
Closed 14 years ago
Top left re-sizer is masked by the Minefield Button
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b3
Tracking | Status | |
---|---|---|
blocking2.0 | --- | betaN+ |
People
(Reporter: jmjjeffery, Assigned: Felipe)
References
Details
Attachments
(1 file)
1.81 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
Trying to access the top left re-sizer in Win7 using today's nightly build is impossible. It seems that the area in the top-left of the browser is being captured by the Minefield/Firefox button.
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100628 Minefield/3.7a6pre ID:20100628035917
Comment 1•15 years ago
|
||
Not sure what we want to do here - probably just adjust the hit zone a little.
Faaborg/Dao?
blocking2.0: ? → beta2+
Assignee | ||
Comment 2•15 years ago
|
||
A little hitzone protection was added around the Firefox button so that resizers wouldn't take over the clickable area of the button. The protection was too agressive on that corner, but reclaiming some pixels to the top-left resizer should be easy.
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Comment 3•15 years ago
|
||
yeah as long as the pixels match the hit zones we should be fine.
Comment 4•15 years ago
|
||
If possible can we get this fixed today? It feels rather awkward having to draw the bottom right to resize a window.
Assignee | ||
Comment 7•14 years ago
|
||
Upon further investigation, the root of the problem was that the top-left resizer is in an area where there's no content to receive the hittest messages, so the hittest falls back to the default behavior of considering the point as inside the client area.
Jimm, I believe that this is the solution we talked about. With the patch, we don't send the hittest messages to safeguard the border areas where we're sure that there's no content being rendered.
Attachment #458036 -
Flags: review?(jmathies)
Updated•14 years ago
|
blocking2.0: beta2+ → betaN+
Comment 8•14 years ago
|
||
Comment on attachment 458036 [details] [diff] [review]
Fix
works great!
Attachment #458036 -
Flags: review?(jmathies) → review+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 9•14 years ago
|
||
Not in trunk yet?
Comment 10•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b3
You need to log in
before you can comment on or make changes to this bug.
Description
•