575250 - AssertJS failure due to default Boomarks Toolbar removal in testVerifyDefaultBookmarks (testDefaultBookmarks/test1.js)

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

MODULE: restartTests/testDefaultBookmarks/test1.js
TEST:   testVerifyDefaultBookmarks
FAIL:   Controller.assertJS("subject.source.path == subject.target.path")
BRANCH: 3.7

With the removal of the bookmarks toolbar per default we cannot check the entries on the bookmarks toolbar directly. We will have to do the following steps:

* Ensure the Toolbar is not visible
* Enable the Bookmarks Toolbar
* Run the existing tests

Comment 1

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Attachment: Added check for bookmarks toolbar defaulting to collapsed, opened it for rest of test.

Added an assertion for the default toolbar state, then opened it to enable the rest of the test.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Interim fix landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/6da1ebc07f12

I think it would be helpful to also have a helper function in the ToolbarAPI which would allow us to toggle toolbars. We can do that in a follow-up bug.

Comment 3

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

This test is failing again in recent builds.  The interim fix we used doesn't initialize the toolbar, so the bookmarks aren't actually seen by automation.  Will be checking in a new fix after dynamic menu handling is in MozMill (bug 474486).

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Geo, can you please continue to work on this failure? Mozmill 1.5 is now in use on all of our machines. Btw. we wouldn't have to necessarily use the main menu make the bookmarks menu visible. There are two other options:

* via the context menu of the toolbars
* menu entry in the bookmarks button called "View Bookmarks Toolbar"

Would be nice to get this fixed so we will have non-failing restart tests.

Comment 5

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Henrik, thanks for the pointers on the other options.  Let me see what I can turn around on this in short order.

Comment 6

[Aaron Train [:aaronmt]]

I filed a separate bug today working on XPath issues in this same test, if this bug will encompass those particular issues, please feel free to close and dupe mine (bug 594023)

Comment 8

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Attachment: Changed XPath to toolbar, showing toolbar via menu

Quick note, "const gTimeout" at top probably isn't proper style for new files, but is consistent with the style already established in this file so I'm sticking with it.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 477212 [details] [diff] [review]
Changed XPath to toolbar, showing toolbar via menu

Looks fine to me. Passes on OS X. Geo will make sure it also passes on Windows and Linux. There are only some minor nits with styles I will address before the checkin.

Comment 10

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Checked on Win7 and Linux, passed w/ no problems.  Think it's ready for landing once it looks like you want it. :)

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Thanks Geo! Landed on default as:
http://hg.mozilla.org/qa/mozmill-tests/rev/6e04a1611df8

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.