575271 - The new windows button and tabs-on-bottom don't mix well under XP

Status: RESOLVED DUPLICATE of bug 574454

(Firefox :: Toolbars and Customization, defect)

Description

[Nochum Sossonko [:Natch]]

Attachment: screenshot

You get an extra line of blue XP themed window-frame in which the button resides. Under XP the button doesn't go up into the titlebar part of the window frame, it is placed underneath with the tabs. However, when the tabs are on bottom, it just looks awkward. Screenshot attached.

Comment 1

[Nochum Sossonko [:Natch]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a6pre) Gecko/20100628 Minefield/3.7a6pre rev: 9c85f9aaec8c

Comment 2

[Peter Henkel [:Terepin]]

That is just temporary, until Drawing in Title Bar for XP land. You just have to wait.

Comment 3

[Nochum Sossonko [:Natch]]

Is there a bug # for where that is being tracked? You can dupe to that bug if so...

Comment 4

[Peter Henkel [:Terepin]]

https://bugzilla.mozilla.org/show_bug.cgi?id=574434
https://bugzilla.mozilla.org/show_bug.cgi?id=513162

Comment 5

[Nochum Sossonko [:Natch]]

I don't see how those are related. Either way, both bug fixes are incorporated in the build I was using.

Comment 6

[Peter Henkel [:Terepin]]

That blue stripe probably comes from bug 574434 and in bug 513162 is being tracked Drawing in Title Bar for Windows, regardless if it is in Aero or non-Aero enviroment. Unless someone will create another bug for it.

Comment 7

[[not reading bugmail]]

(In reply to comment #6)
> That blue stripe probably comes from bug 574434 and in bug 513162 is being
> tracked Drawing in Title Bar for Windows, regardless if it is in Aero or
> non-Aero enviroment. Unless someone will create another bug for it.

For example we're seeing the same on Windows 7 Classic, and Windows 7 Basic mode.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

The Firefox button shouldn't be showing up in those modes - we should be showing the menuBar. Have you manually turned the menuBar off?

Comment 9

[Nochum Sossonko [:Natch]]

The menubar shows when I put the tabs on top as well, so long as I don't "manually" turn it off. Both are manual adjustments, there is no "put the tabs on top and show the menu button" button far as I know...

Comment 10

[:Gavin Sharp [email: [e-mail]]]

That screenshot is how I would expect things to look until bug 574454 is fixed.

Comment 11

[[not reading bugmail]]

The default new profile created when I have Win 7 Classic, shows App Menu button and Tabs on Top.

Comment 12

[pal-moz]

(In reply to comment #11)
> The default new profile created when I have Win 7 Classic, shows App Menu
> button and Tabs on Top.

intended.

On Windows, "Tabs on Top" is ON by default, bug 571992
On Windows 7/Vista, "Firefox Button" is ON by default, bug 574435

Comment 13

[Dietrich Ayala (:dietrich)]

(In reply to comment #10)
> That screenshot is how I would expect things to look until bug 574454 is fixed.

Cc'ing Jim. Will that bug fix this?

Comment 14

[Jim Mathies [:jimm]]

(In reply to comment #13)
> (In reply to comment #10)
> > That screenshot is how I would expect things to look until bug 574454 is fixed.
> 
> Cc'ing Jim. Will that bug fix this?

No.  bug 574454 is for providing the ability to render our own window frame and contents via xul, css, and the native theme library. A new browser bug needs to be filed for implementing the custom frame in the browser and any other window we want to support the new fx button.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

I think the appropriate blocker is bug 574454 (and the required UI bugs to get the XP look how it's supposed to be - shorlander, can you make sure those are nominated for blocking?) and am pretty sure that this is either INVALID or DUPE.

Comment 16

[Alex Faaborg [:faaborg] (Firefox UX)]

setting to dupe bug 574454