Closed Bug 575374 Opened 10 years ago Closed 10 years ago

Optimize ::GetInnerHTML (part 2)

Categories

(Core :: DOM: Core & HTML, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch wip (obsolete) — Splinter Review
There are many small things we can optimize in serializers.
Reduce virtual calls, some string handling optimization, etc.
Attached patch wip2Splinter Review
Attachment #454602 - Attachment is obsolete: true
Comment on attachment 454851 [details] [diff] [review]
wip2

So this moves mBodyOnly and mInBody from XHTMLSerializer to XMLSerializer so that few methods can be de-virtualized.

In theory HTMLAtomTagToId -> HTMLCaseSensitiveAtomTagToId change does
affect to behavior. But it should do now the right thing, since we get 
the atom always from an element, and HTML elements
have lowercase Tag(). In fact, I don't know why we have 
case-insensitive HTMLAtomTagToId.

Other changes are addref/release removal related to SetCachedEncoder and
faster sibling iteration.
Attachment #454851 - Flags: review?(jst)
Attachment #454851 - Flags: review?(jst) → review+
http://hg.mozilla.org/mozilla-central/rev/99ea6685c1f7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.