575396 - treehydra: fix template and enum handling of dehydra_convert, add gimple_num_args, banish USING_DECLs

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Ehren Metcalfe]

Attachment: patch

4.5 switched to using CONST_DECL for some (all?) enum fields (this is already handled in dehydra_types.c). The other fixes are for issues encountered when running the analysis suite. Note that the USING_DECL fix is to prevent these trees from being seen by process_tree_decl.

Comment 1

[(dormant account)]

Comment on attachment 454631 [details] [diff] [review]
patch

>+// Test enum handling of dehydra_convert
>+function process_tree(fn) {
>+  let cfg = function_decl_cfg(fn);
>+  for (let bb in cfg_bb_iterator(cfg)) {
>+    for (let isn in bb_isn_iterator(bb)) {
>+      if (isn.tree_code() != GIMPLE_ASSIGN)
>+        continue;
>+      let lhs = gimple_op(isn, 0);
>+      let t = TREE_TYPE(lhs);
>+      t = dehydra_convert(t);
>+      new EnumTestCase(t).run(r);
>+    }
>+  }
>+}

There should be a cfg->isn iterator to skip these nested loops in every friggin script. If there isn't one already please add a cfg_isn_iterator

Comment 2

[Ehren Metcalfe]

Attachment: patch v2

added cfg_isn_iterator, changed test case to use it, carrying over r+.

Comment 3

[Ehren Metcalfe]

http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/88b314bba36b