575398 - dehydra: circular typedef field generated with attribute __aligned__

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Ehren Metcalfe]

Turns out the fix was pretty easy, although this seems like a genuine gcc bug in that DECL_ORIGINAL_TYPE(TYPE_NAME(type)) == type. As far as I can tell only __attribute__((__aligned__)) triggers this weirdness.

Comment 1

[Ehren Metcalfe]

Attachment: patch

Comment 2

[(dormant account)]

Comment on attachment 454634 [details] [diff] [review]
patch

please file a gcc bug to

Comment 3

[Ehren Metcalfe]

http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/2f6776affb9f

Comment 4

[Mike Hommey [:glandium]]

Here is what I get with this patch applied:

Test Failure: 
    Test command: /usr/bin/g++-4.5 -c -fplugin=../gcc_dehydra.so -o /dev/null -fplugin-arg-gcc_dehydra-script=test_typedef_aligned.js typedef_aligned.cc
    Failure msg: Expected 'OK' output; Errors:
 typedef_aligned.cc:2:37: error: Must be 5 tests run, instead ran 1

Comment 5

[Ehren Metcalfe]

Attachment: test fix

Thanks for pointing this out. I can confirm that with 4.5 tip this struct is only visited once (as opposed to with 4.5.0). I've changed the test to require that 1 visit minimum is made without hardcoding the number of visits.

Mike, I could just land it, but do you mind giving this a look?

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 456910 [details] [diff] [review]
test fix

I can't comment on the correctness, but at least, the test passes. Thanks.

Comment 7

[Ehren Metcalfe]

http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/e0c21d67fa42