Closed Bug 575405 Opened 14 years ago Closed 14 years ago

sleep and waitForEval should use the same underlying function if possible

Categories

(Testing Graveyard :: Mozmill, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 579943

People

(Reporter: k0scist, Unassigned)

Details

Attachments

(1 file)

both sleep and waitForEval use the same general pattern. However, code is repeated. they should go through the same code path. See possible patch. Caveats: it is noted in the patch (per previous comments) // This blocks execution until our while loop condition is invalidated. Note // that you must use a simple boolean expression for the loop, a function call // will not work. In fact, I use a function call. I haven't noticed any bad effect in real life. However, this is not to say that something bad happens that I don't notice.
Jeff, looks like it's that bug you mentioned yesterday, which I have now covered with bug 579943. Shall we dupe it?
(In reply to comment #1) > Jeff, looks like it's that bug you mentioned yesterday, which I have now > covered with bug 579943. Shall we dupe it? Yep; done
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: