575406 - Installing Persona turns Aero custom titlebar window corners square

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[[not reading bugmail]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a6pre) Gecko/20100628 Minefield/3.7a6pre Firefox/3.6.6
Build Identifier: 

Preview/Installing persona on Aero Glass with custom App menu drawing in the titlebar turns the window border corners from round to square.

Reproducible: Always

Steps to Reproduce:
1. Disable Menu Bar to show App Menu button
2. Turn on Aero Theme Glass if that is not enabled.
3. Go to URL
4. Hover over a persona

Actual Results:  
Corners are turned square

Expected Results:  
Corners are rounded or match Aero theme design.

Comment 1

[[not reading bugmail]]

Attachment: The corners look kinda squarish on the left compared to standard theme on the right

Comment 2

[[not reading bugmail]]

Thanks for moving this over to right bug.  I noticed something, when you mouse over a personas off and on, it looks like something is drawing in the top half of each border edge.

Comment 3

[Shawn Thompson]

I filed another bug, not only does it do that, but I also lose the min/max/close buttons too. Odd.

Comment 4

[[not reading bugmail]]

(In reply to comment #3)
> I filed another bug, not only does it do that, but I also lose the
> min/max/close buttons too. Odd.

Probably bug 574833, though it was for painting over the controls, but they might be gone now too see that bug for more.

Comment 5

[Jim Mathies [:jimm]]

(In reply to comment #2)
> Thanks for moving this over to right bug.  I noticed something, when you mouse
> over a personas off and on, it looks like something is drawing in the top half
> of each border edge.

A few people have noticed that as well. Some sort of a drawing artifact. When the personas folks get to updating personas to support the new titlebar, I'm sure they'll address it.

Comment 6

[aicitman]

(In reply to comment #5)
> When the personas folks get to updating personas to support the new titlebar,  > I'm sure they'll address it.

Well, I'm not. Because this has nothing to do with the persona. It has to do with firefox. And proof of that is, that even before it downloads the picture, it's squared. (it just changes the background color - of the square). Although, what I think you should do to bug 574833, you should do here also - tell the painter never to paint out of those edges.

Comment 7

[Jim Mathies [:jimm]]

(In reply to comment #6)
> (In reply to comment #5)
> > When the personas folks get to updating personas to support the new titlebar,  > I'm sure they'll address it.
> 
> Well, I'm not. Because this has nothing to do with the persona. It has to do
> with firefox. And proof of that is, that even before it downloads the picture,
> it's squared. (it just changes the background color - of the square). Although,
> what I think you should do to bug 574833, you should do here also - tell the
> painter never to paint out of those edges.

This has something to do with us painting an opaque background to the top of the window. Originally the plan was to paint personas across the entire surface, including borders, and solve the rounding problem then, maybe using a region in widget when we paint. I'm not sure if that's a goal for Fx 4 at this point. If it is, we would address this after that work completes. If not, we'll have to find some sort medium ground. Personally I'm leaning toward pushing persona skinning down off the window border. Although I'm not sure we can do that to background-images via css.

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Fixed by patch from bug 574833

(For the record, the issue was that the top glass margin needs to have a minimum height to show the rounded borders)