575464 - "ASSERTION: parser should have ensured no nonnegative lengths"

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: parser should have ensured no nonnegative lengths: 'aValue.IsCalcUnit()', file /builds/slave/mozilla-central-macosx-debug/build/layout/style/nsRuleNode.cpp, line 423

SetCoord [layout/style/nsRuleNode.cpp:424]
nsRuleNode::GetShadowData(nsCSSValueList*, nsStyleContext*, int, int&) [layout/style/nsRuleNode.cpp:3335]
nsRuleNode::ComputeTextData(void*, nsCSSStruct const&, nsStyleContext*, nsRuleNode*, nsRuleNode::RuleDetail, int) [layout/style/nsRuleNode.cpp:3408]
nsRuleNode::WalkRuleTree(nsStyleStructID, nsStyleContext*, nsRuleData*, nsCSSStruct*) [layout/style/nsStyleStructList.h:89]
nsRuleNode::GetTextData(nsStyleContext*) [layout/style/nsRuleNode.cpp:1681]
nsRuleNode::GetStyleText(nsStyleContext*, int) [layout/style/nsStyleStructList.h:89]
nsStyleContext::DoGetStyleText(int) [layout/style/nsStyleStructList.h:89]
nsStyleContext::GetStyleText() [nsStyleStructList.h:89]
nsIFrame::GetStyleText() const [nsStyleStructList.h:89]
nsHTMLReflowState::Init(nsPresContext*, int, int, nsMargin const*, nsMargin const*) [layout/generic/nsHTMLReflowState.cpp:278]
nsHTMLReflowState::Init(nsPresContext*, int, int, nsMargin const*, nsMargin const*) [layout/generic/nsHTMLReflowState.cpp:178]
nsLineLayout::ReflowFrame(nsIFrame*, unsigned int&, nsHTMLReflowMetrics*, int&) [layout/generic/nsLineLayout.cpp:773]
nsInlineFrame::ReflowInlineFrame(nsPresContext*, nsHTMLReflowState const&, nsInlineFrame::InlineReflowState&, nsIFrame*, unsigned int&) [layout/generic/nsInlineFrame.cpp:716]
nsInlineFrame::ReflowFrames(nsPresContext*, nsHTMLReflowState const&, nsInlineFrame::InlineReflowState&, nsHTMLReflowMetrics&, unsigned int&) [layout/generic/nsInlineFrame.cpp:580]
nsInlineFrame::Reflow(nsPresContext*, nsHTMLReflowMetrics&, nsHTMLReflowState const&, unsigned int&) [layout/generic/nsInlineFrame.cpp:437]
nsLineLayout::ReflowFrame(nsIFrame*, unsigned int&, nsHTMLReflowMetrics*, int&) [layout/generic/nsLineLayout.cpp:853]
nsInlineFrame::ReflowInlineFrame(nsPresContext*, nsHTMLReflowState const&, nsInlineFrame::InlineReflowState&, nsIFrame*, unsigned int&) [layout/generic/nsInlineFrame.cpp:716]
nsInlineFrame::ReflowFrames(nsPresContext*, nsHTMLReflowState const&, nsInlineFrame::InlineReflowState&, nsHTMLReflowMetrics&, unsigned int&) [layout/generic/nsInlineFrame.cpp:580]
nsInlineFrame::Reflow(nsPresContext*, nsHTMLReflowMetrics&, nsHTMLReflowState const&, unsigned int&) [layout/generic/nsInlineFrame.cpp:437]
nsLineLayout::ReflowFrame(nsIFrame*, unsigned int&, nsHTMLReflowMetrics*, int&) [layout/generic/nsLineLayout.cpp:853]
nsBlockFrame::ReflowInlineFrame(nsBlockReflowState&, nsLineLayout&, nsLineList_iterator, nsIFrame*, LineReflowStatus*) [layout/generic/nsBlockFrame.cpp:3722]
nsBlockFrame::DoReflowInlineFrames(nsBlockReflowState&, nsLineLayout&, nsLineList_iterator, nsFlowAreaRect&, int&, nsFloatManager::SavedState*, int*, LineReflowStatus*, int) [layout/generic/nsBlockFrame.cpp:3517]
nsBlockFrame::ReflowInlineFrames(nsBlockReflowState&, nsLineList_iterator, int*) [layout/generic/nsBlockFrame.cpp:3371]
nsBlockFrame::ReflowLine(nsBlockReflowState&, nsLineList_iterator, int*) [layout/generic/nsBlockFrame.cpp:2467]
nsBlockFrame::ReflowDirtyLines(nsBlockReflowState&) [layout/generic/nsBlockFrame.cpp:1907]
nsBlockFrame::Reflow(nsPresContext*, nsHTMLReflowMetrics&, nsHTMLReflowState const&, unsigned int&) [layout/generic/nsBlockFrame.cpp:1009]
nsBlockReflowContext::ReflowBlock(nsRect const&, int, nsCollapsingMargin&, int, int, nsLineBox*, nsHTMLReflowState&, unsigned int&, nsBlockReflowState&) [layout/generic/nsBlockReflowContext.cpp:310]
nsBlockFrame::ReflowBlockFrame(nsBlockReflowState&, nsLineList_iterator, int*) [layout/generic/nsBlockFrame.cpp:3090]
nsBlockFrame::ReflowLine(nsBlockReflowState&, nsLineList_iterator, int*) [layout/generic/nsBlockFrame.cpp:2412]
nsBlockFrame::ReflowDirtyLines(nsBlockReflowState&) [layout/generic/nsBlockFrame.cpp:1907]
nsBlockFrame::Reflow(nsPresContext*, nsHTMLReflowMetrics&, nsHTMLReflowState const&, unsigned int&) [layout/generic/nsBlockFrame.cpp:1009]
nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, nsHTMLReflowMetrics&, nsHTMLReflowState const&, int, int, unsigned int, unsigned int&, nsOverflowContinuationTracker*) [layout/generic/nsContainerFrame.cpp:738]
nsCanvasFrame::Reflow(nsPresContext*, nsHTMLReflowMetrics&, nsHTMLReflowState const&, unsigned int&) [layout/generic/nsCanvasFrame.cpp:504]
nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, nsHTMLReflowMetrics&, nsHTMLReflowState const&, int, int, unsigned int, unsigned int&, nsOverflowContinuationTracker*) [layout/generic/nsContainerFrame.cpp:738]
nsHTMLScrollFrame::ReflowScrolledFrame(ScrollReflowState*, int, int, nsHTMLReflowMetrics*, int) [layout/generic/nsGfxScrollFrame.cpp:508]
nsHTMLScrollFrame::ReflowContents(ScrollReflowState*, nsHTMLReflowMetrics const&) [layout/generic/nsGfxScrollFrame.cpp:601]
nsHTMLScrollFrame::Reflow(nsPresContext*, nsHTMLReflowMetrics&, nsHTMLReflowState const&, unsigned int&) [layout/generic/nsGfxScrollFrame.cpp:807]
nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, nsHTMLReflowMetrics&, nsHTMLReflowState const&, int, int, unsigned int, unsigned int&, nsOverflowContinuationTracker*) [layout/generic/nsContainerFrame.cpp:738]
ViewportFrame::Reflow(nsPresContext*, nsHTMLReflowMetrics&, nsHTMLReflowState const&, unsigned int&) [layout/generic/nsViewportFrame.cpp:285]
PresShell::DoReflow(nsIFrame*, int) [layout/base/nsPresShell.cpp:7424]
PresShell::ProcessReflowCommands(int) [layout/base/nsPresShell.cpp:7553]
PresShell::FlushPendingNotifications(mozFlushType) [layout/base/nsPresShell.cpp:4816]
nsDocument::FlushPendingNotifications(mozFlushType) [content/base/src/nsDocument.cpp:6123]
nsDocLoader::DocLoaderIsEmpty(int) [uriloader/base/nsDocLoader.cpp:760]
nsDocLoader::OnStopRequest(nsIRequest*, nsISupports*, unsigned int) [uriloader/base/nsDocLoader.cpp:703]
nsLoadGroup::RemoveRequest(nsIRequest*, nsISupports*, unsigned int) [netwerk/base/src/nsLoadGroup.cpp:680]
nsDocument::DoUnblockOnload() [content/base/src/nsDocument.cpp:6948]
nsDocument::UnblockOnload(int) [content/base/src/nsDocument.cpp:6886]
nsDocument::DispatchContentLoadedEvents() [content/base/src/nsDocument.cpp:3890]
nsRunnableMethodImpl<void (nsDocument::*)(), true>::Run() [nsThreadUtils.h:348]
nsThread::ProcessNextEvent(int, int*) [xpcom/threads/nsThread.cpp:547]
NS_ProcessPendingEvents_P(nsIThread*, unsigned int) [nsThreadUtils.cpp:200]
nsBaseAppShell::NativeEventCallback() [widget/src/xpwidgets/nsBaseAppShell.cpp:127]
nsAppShell::ProcessGeckoEvents(void*) [widget/src/cocoa/nsAppShell.mm:395]
CoreFoundation + 0x3f0fb
CoreFoundation + 0x3cbbf
CoreFoundation + 0x3c094
CoreFoundation + 0x3bec1
HIToolbox + 0x34f9c
HIToolbox + 0x34d51
HIToolbox + 0x34bd6
AppKit + 0x48a89
-AppKit + 0x482ca
-AppKit + 0xa55b
nsAppShell::Run() [widget/src/cocoa/nsAppShell.mm:747]
nsAppStartup::Run() [toolkit/components/startup/src/nsAppStartup.cpp:192]
XRE_main [toolkit/xre/nsAppRunner.cpp:3624]
main [browser/app/nsBrowserApp.cpp:158]
firefox-bin + 0x148e

Comment 1

[Ryan VanderMeulen [:RyanVM]]

No longer happens on trunk.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6eb58cdcd325

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6eb58cdcd325