575509 - Port |Bug 516758 - Remove more options from configure| to comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Takanori MATSUURA]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; ja; rv:2.0b2pre) Gecko/20100629 Fedora/4.0b2pre-0.b2pre.2010062914.fc13 Minefield/3.7a6pre Firefox/3.6.4
Build Identifier: 

As per bug 516758 comment #39.

Reproducible: Always

Comment 1

[Takanori MATSUURA]

Attachment: Just copy from attachment 454457.

(In reply to bug 516758 comment #39)
> (From update of attachment 454457 [details] [diff] [review])
> >+dnl ========================================================
> > dnl = Enable help viewer (off by default)
> > dnl ========================================================
> 
> Please keep this option intact as far as c-c has it. It was only retained in
> _any_ form in m-c because c-c actually uses it. My reasoning -- We should allow
> SeaMonkey to build without this (--disable-*) though it has little use for
> Thunderbird.

"MOZ_HELP_VIEWER=1" is explicitly set at suite/confvars.sh now, so I suppose help viewer is still enabled in SeaMonkey and we can remove this option from configure script.

Comment 2

[Justin Wood (:Callek)]

(In reply to comment #1)
> Created an attachment (id=454776) [details]
> Just copy from attachment 454457 [details] [diff] [review].
> 
> (In reply to bug 516758 comment #39)
> > (From update of attachment 454457 [details] [diff] [review] [details])
> > >+dnl ========================================================
> > > dnl = Enable help viewer (off by default)
> > > dnl ========================================================
> > 
> > Please keep this option intact as far as c-c has it. It was only retained in
> > _any_ form in m-c because c-c actually uses it. My reasoning -- We should allow
> > SeaMonkey to build without this (--disable-*) though it has little use for
> > Thunderbird.
> 
> "MOZ_HELP_VIEWER=1" is explicitly set at suite/confvars.sh now, so I suppose
> help viewer is still enabled in SeaMonkey and we can remove this option from
> configure script.

Actually thinking about it more, even if we did keep the --enable/disable choice _here_ it would not affect things anyway, since m-c would still only read from our confvars.sh. Given that, r+

Comment 3

[Takanori MATSUURA]

Thanks.

Comment 4

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/a8edda118d97