Closed Bug 575514 Opened 11 years ago Closed 11 years ago

Make DROP_DEAD not die for releases, and allow override by ENV var

Categories

(Core :: Networking: HTTP, defect)

Product:
Core
Component:
Networking: HTTP
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)

References

Details

Attachments

(1 file)

Make DROP_DEAD not die for releases, and allow override by ENV var
6.30 KB, patch
jdm
: review+
Details | Diff | Splinter Review 
As discussed on IRC with cjones and bz, for now we're leaving DROP_DEAD in necko, but making it only emit a warning for release builds.  For debug and test builds, we die by default, but the error msg includes instruction on how to disable the abort by setting NECKO_ERRORS_ARE_FATAL=0 in your environment.

Opened bug 575494 to deal with removing DROP_DEAD entirely when we're ready.
Attachment #454778 - Flags: review?(josh)
Two nits:

>const char * e = PR_GetEnv("NECKO_ERRORS_ARE_FATAL");

You cannot be neutral in the pointer-snuggling debate.  Choose a side.

>  return QueryInterface(aIID, result);
>} else {

Else after return.  Scrap it.

Otherwise, it looks decent. r=jdm
Attachment #454778 - Flags: review?(josh) → review+
http://hg.mozilla.org/projects/electrolysis/rev/6ebee222742d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee: nobody → jduell.mcbugs
You need to log in before you can comment on or make changes to this bug.