Closed
Bug 575514
Opened 15 years ago
Closed 15 years ago
Make DROP_DEAD not die for releases, and allow override by ENV var
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)
References
Details
Attachments
(1 file)
|
6.30 KB,
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
As discussed on IRC with cjones and bz, for now we're leaving DROP_DEAD in necko, but making it only emit a warning for release builds. For debug and test builds, we die by default, but the error msg includes instruction on how to disable the abort by setting NECKO_ERRORS_ARE_FATAL=0 in your environment.
Opened bug 575494 to deal with removing DROP_DEAD entirely when we're ready.
Attachment #454778 -
Flags: review?(josh)
|
||
Comment 1•15 years ago
|
||
Two nits:
>const char * e = PR_GetEnv("NECKO_ERRORS_ARE_FATAL");
You cannot be neutral in the pointer-snuggling debate. Choose a side.
> return QueryInterface(aIID, result);
>} else {
Else after return. Scrap it.
Otherwise, it looks decent. r=jdm
|
|
||
Updated•15 years ago
|
Attachment #454778 -
Flags: review?(josh) → review+
|
Assignee | |
Comment 2•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Assignee: nobody → jduell.mcbugs
You need to log in
before you can comment on or make changes to this bug.
Description
•